NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-104374: don't inline comprehensions in non-function scopes#104519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

carljm wants to merge3 commits intopython:mainfromcarljm:709funconly

Closed

gh-104374: don't inline comprehensions in non-function scopes#104519

carljm wants to merge3 commits intopython:mainfromcarljm:709funconly

Conversation

Copy link

Member

carljm commentedMay 16, 2023•
edited by bedevere-bot
Loading

This PR updates and adds comprehension tests to mandate the same scoping and name-visibility rules as in Python 3.11, including in class scopes. These are the changes inLib/tests/test_listcomps.py.

Then there is one change inPython/symtable.c, to only inline comprehensions that occur within functions.

The rest of the PR is purely a partial rollback of#101441, removing those parts of the implementation of PEP 709 that were required only for inlining module and class-level comprehensions.

Issue:List comprehensions now have access to the enclosing class scope #104374

pythongh-104374: don't inline comprehensions in non-function scopes

9d452fb

bedevere-bot mentioned this pull request

May 16, 2023

List comprehensions now have access to the enclosing class scope#104374

Closed

update NEWS and What's New

2c47a75

This was referencedMay 16, 2023

gh-104374: Remove access to class scopes for inlined comprehensions#104528

Merged

PEP 709, for the third and (hopefully) final timepython/steering-council#192

Closed

Merge branch 'main' into 709funconly

b1bb3a7

* main: (26 commits)pythonGH-101520: Move tracemalloc functionality into core, leaving interface in Modules. (python#104508)  typing: Add more tests for TypeVar (python#104571)pythongh-104572: Improve error messages for invalid constructs in PEP 695 contexts (python#104573)  typing: Use PEP 695 syntax in typing.py (python#104553)pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (python#102508)pythongh-104469: Update README.txt for _testcapi (pythongh-104529)pythonGH-103092: isolate `_elementtree` (python#104561)pythongh-104050: Add typing to Argument Clinic converters (python#104547)pythonGH-103906: Remove immortal refcounting in the interpreter (pythonGH-103909)pythongh-87474: Fix file descriptor leaks in subprocess.Popen (python#96351)pythonGH-103092: isolate `pyexpat`  (python#104506)pythongh-75367: Fix data descriptor detection in inspect.getattr_static (python#104517)pythongh-104050: Add more annotations to `Tools/clinic.py` (python#104544)pythongh-104555: Fix isinstance() and issubclass() for runtime-checkable protocols that use PEP 695 (python#104556)pythongh-103865: add monitoring support to LOAD_SUPER_ATTR (python#103866)  CODEOWNERS: Assign new PEP 695 files to myself (python#104551)pythonGH-104510: Fix refleaks in `_io` base types (python#104516)pythongh-104539: Fix indentation error in logging.config.rst (python#104545)pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543)pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538)  ...