Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104469: Convert _testcapi/watchers.c to use AC#104503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 3 commits intopython:mainfromsobolevn:issue-104469-watchers
May 15, 2023

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commentedMay 15, 2023•
edited by bedevere-bot
Loading

@sobolevn
Copy link
MemberAuthor

As far as I know,Test Hypothesis failure is not related

Eclips4 reacted with thumbs up emoji

@erlend-aaslanderlend-aasland self-requested a reviewMay 15, 2023 11:40
@erlend-aasland
Copy link
Contributor

Also, remember to make clinic before pushing.

@erlend-aasland
Copy link
Contributor

BTW, the rest of the tests should be cancelled if "Check if generated files are up to date" fails. CC. GitHub wizard@hugovk.

@hugovk
Copy link
Member

hugovk commentedMay 15, 2023•
edited by AlexWaygood
Loading

"Check for source changes" is a gating step, but "Check if generated files are up to date" isn't:

image

https://github.com/python/cpython/actions/runs/4980218331?pr=104503

This is how the other steps depend on "Check four source changes" inhttps://github.com/python/cpython/blob/b378d991f8cd41c33416e590cb83472cce1d6b98/.github/workflows/build.yml:

needs:check_sourceif:needs.check_source.outputs.run_tests == 'true'

@erlend-aaslanderlend-aasland merged commit456d566 intopython:mainMay 15, 2023
carljm added a commit to carljm/cpython that referenced this pull requestMay 16, 2023
* main:pythonGH-104510: Fix refleaks in `_io` base types (python#104516)pythongh-104539: Fix indentation error in logging.config.rst (python#104545)pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543)pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538)pythongh-64595: Fix write file logic in Argument Clinic (python#104507)pythongh-104523: Inline minimal PGO rules (python#104524)pythongh-103861: Fix Zip64 extensions not being properly applied in some cases (python#103863)pythongh-69152: add method get_proxy_response_headers to HTTPConnection class (python#104248)pythongh-103763: Implement PEP 695 (python#103764)pythongh-104461: Run tkinter test_configure_screen on X11 only (pythonGH-104462)pythongh-104469: Convert _testcapi/watchers.c to use Argument Clinic (python#104503)pythongh-104482: Fix error handling bugs in ast.c (python#104483)pythongh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization (pythongh-104437)pythonGH-102613: Fix recursion error from `pathlib.Path.glob()` (pythonGH-104373)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@corona10corona10corona10 left review comments

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn@erlend-aasland@hugovk@corona10@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp