Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104456: Fix ref leak in _ctypes.COMError#104457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 5 commits intopython:mainfromEclips4:issue-104456
May 14, 2023

Conversation

Eclips4
Copy link
Member

@Eclips4Eclips4 commentedMay 13, 2023•
edited by bedevere-bot
Loading

@Eclips4
Copy link
MemberAuthor

Seems that related to#104020
@erlend-aasland

erlend-aasland reacted with thumbs up emoji

@AlexWaygoodAlexWaygood added the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelMay 13, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@AlexWaygood for commit8dbad09 🤖

If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelMay 13, 2023
@Eclips4
Copy link
MemberAuthor

Eclips4 commentedMay 13, 2023•
edited
Loading

Thanks Alex for the buildbots start. But, no one from buildbots use a windows system.
In issue I've mentioned that this refleak only reproducible on Windows, because COMError exist only on Windows.
So... buildbots can't catch this refleak :(
However, maybe add a one buildbot with windows system to buildbots ecosystem? I think it's will be useful.
(of course, this should be a another issue)

AlexWaygood reacted with thumbs up emoji

@AlexWaygood
Copy link
Member

!buildbot Windows.*Refleak

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@AlexWaygood for commit8dbad09 🤖

The command will test the builders whose names match following regular expression:Windows.*Refleak

The builders matched are:

@AlexWaygood
Copy link
Member

!buildbot .*Windows.Refleak.

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@AlexWaygood for commit8dbad09 🤖

The command will test the builders whose names match following regular expression:.*Windows.*Refleak.*

The builders matched are:

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add aPy_tp_clear slot and do the work there. You can call that function from dealloc. Also, the traverse function must be updated similarly.

Eclips4 reacted with thumbs up emoji
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland
Copy link
Contributor

Also, in dealloc we first untrack from GC, then we clear.

@Eclips4
Copy link
MemberAuthor

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

@erlend-aasland
Copy link
Contributor

I left some more remarks. I'll follow this up tomorrow.

Eclips4 reacted with heart emoji

Eclips4and others added2 commitsMay 14, 2023 01:53
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@sunmy2019
Copy link
Member

Could you let me know if you've confirmed the error is fixed on Windows?@Eclips4

@Eclips4
Copy link
MemberAuthor

Could you let me know if you've confirmed the error is fixed on Windows?@Eclips4

Yeah, refleak are gone:

 ./python-mtest-R3:3test_ctypesRunningDebug|x64interpreter...0:00:00Runtestssequentially0:00:00 [1/1]test_ctypesbeginning6repetitions123456a=5,b=10,c=15a=5,b=10,c=15.a=5,b=10,c=15a=5,b=10,c=15.a=5,b=10,c=15a=5,b=10,c=15.a=5,b=10,c=15a=5,b=10,c=15.a=5,b=10,c=15a=5,b=10,c=15.a=5,b=10,c=15a=5,b=10,c=15.test_ctypespassedin31.2sec==Testsresult:SUCCESS==1testOK.Totalduration:31.3secTestsresult:SUCCESS

Also, thanks for your help!

sunmy2019 reacted with thumbs up emoji

@erlend-aaslanderlend-aasland changed the titlegh-104456: Fix ref leak in test_ctypesgh-104456: Fix ref leak in _ctypes.COMErrorMay 14, 2023
@erlend-aasland
Copy link
Contributor

Thanks!

Eclips4 reacted with heart emoji

@erlend-aaslanderlend-aasland merged commit2cd1c87 intopython:mainMay 14, 2023
@Eclips4Eclips4 deleted the issue-104456 branchMay 14, 2023 21:16
carljm added a commit to carljm/cpython that referenced this pull requestMay 15, 2023
* main: (29 commits)pythongh-101819: Fix _io clinic input for unused base class method stubs (python#104418)pythongh-101819: Isolate `_io` (python#101948)  Bump mypy from 1.2.0 to 1.3.0 in /Tools/clinic (python#104501)pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (python#104495)pythongh-104050: Run mypy on `clinic.py` in CI (python#104421)pythongh-104490: Consistently define phony make targets (python#104491)pythongh-67056: document that registering/unregistering an atexit func from within an atexit func is undefined (python#104473)pythongh-104487: PYTHON_FOR_REGEN must be minimum Python 3.10 (python#104488)pythongh-101282: move BOLT config after PGO (pythongh-104493)pythongh-104469 Convert _testcapi/float.c to use AC (pythongh-104470)pythongh-104456: Fix ref leak in _ctypes.COMError (python#104457)pythongh-98539: Make _SSLTransportProtocol.abort() safe to call when closed (python#104474)pythongh-104337: Clarify random.gammavariate doc entry  (python#104410)  Minor improvements to typing docs (python#104465)pythongh-87092: avoid gcc warning on uninitialized struct field in assemble.c (python#104460)pythonGH-71383: IDLE - Document testing subsets of modules (python#104463)pythongh-104454: Fix refleak in AttributeError_reduce (python#104455)pythongh-75710: IDLE - add docstrings and comments to editor module (python#104446)pythongh-91896: Revert some very noisy DeprecationWarnings for `ByteString` (python#104424)  Add a mention of PYTHONBREAKPOINT to breakpoint() docs (python#104430)  ...
carljm added a commit to carljm/cpython that referenced this pull requestMay 15, 2023
* main: (204 commits)pythongh-101819: Fix _io clinic input for unused base class method stubs (python#104418)pythongh-101819: Isolate `_io` (python#101948)  Bump mypy from 1.2.0 to 1.3.0 in /Tools/clinic (python#104501)pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (python#104495)pythongh-104050: Run mypy on `clinic.py` in CI (python#104421)pythongh-104490: Consistently define phony make targets (python#104491)pythongh-67056: document that registering/unregistering an atexit func from within an atexit func is undefined (python#104473)pythongh-104487: PYTHON_FOR_REGEN must be minimum Python 3.10 (python#104488)pythongh-101282: move BOLT config after PGO (pythongh-104493)pythongh-104469 Convert _testcapi/float.c to use AC (pythongh-104470)pythongh-104456: Fix ref leak in _ctypes.COMError (python#104457)pythongh-98539: Make _SSLTransportProtocol.abort() safe to call when closed (python#104474)pythongh-104337: Clarify random.gammavariate doc entry  (python#104410)  Minor improvements to typing docs (python#104465)pythongh-87092: avoid gcc warning on uninitialized struct field in assemble.c (python#104460)pythonGH-71383: IDLE - Document testing subsets of modules (python#104463)pythongh-104454: Fix refleak in AttributeError_reduce (python#104455)pythongh-75710: IDLE - add docstrings and comments to editor module (python#104446)pythongh-91896: Revert some very noisy DeprecationWarnings for `ByteString` (python#104424)  Add a mention of PYTHONBREAKPOINT to breakpoint() docs (python#104430)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sobolevnsobolevnsobolevn left review comments

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@sunmy2019sunmy2019sunmy2019 approved these changes

Assignees

@erlend-aaslanderlend-aasland

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@Eclips4@bedevere-bot@AlexWaygood@erlend-aasland@sunmy2019@sobolevn
[8]ページ先頭
©2009-2025 Movatter.jp