NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

gh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization#104437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ericsnowcurrently merged 1 commit intopython:mainfromericsnowcurrently:fix-tstate-must-exit

May 15, 2023

Merged

gh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization#104437

ericsnowcurrently merged 1 commit intopython:mainfromericsnowcurrently:fix-tstate-must-exit

May 15, 2023

Conversation

Copy link

Member

ericsnowcurrently commentedMay 12, 2023•
edited by bedevere-bot
Loading

With the move to a per-interpreter GIL, this check slipped through the cracks.

Issue:test__xxsubinterpreters is Occasionally Crashing #104341

Adjust tstate_must_exit() to respect interp fini.

695f76a

ericsnowcurrently added the skip news label

May 12, 2023

ericsnowcurrently requested review fromberkerpeksag,erlend-aasland,1st1,asvetlov,gvanrossum,kumaraditya303 andwillingc ascode owners

May 12, 2023 18:49

bedevere-bot added the awaiting core review label

May 12, 2023

bedevere-bot mentioned this pull request

May 12, 2023

test__xxsubinterpreters is Occasionally Crashing#104341

Closed

ericsnowcurrently merged commit26baa74 intopython:main

May 15, 2023

bedevere-bot removed the awaiting core review label

May 15, 2023

ericsnowcurrently deleted the fix-tstate-must-exit branch

May 15, 2023 19:59

carljm added a commit to carljm/cpython that referenced this pull request

May 16, 2023

Merge branch 'main' into supermon

a6dd626

* main:pythonGH-104510: Fix refleaks in `_io` base types (python#104516)pythongh-104539: Fix indentation error in logging.config.rst (python#104545)pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543)pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538)pythongh-64595: Fix write file logic in Argument Clinic (python#104507)pythongh-104523: Inline minimal PGO rules (python#104524)pythongh-103861: Fix Zip64 extensions not being properly applied in some cases (python#103863)pythongh-69152: add method get_proxy_response_headers to HTTPConnection class (python#104248)pythongh-103763: Implement PEP 695 (python#103764)pythongh-104461: Run tkinter test_configure_screen on X11 only (pythonGH-104462)pythongh-104469: Convert _testcapi/watchers.c to use Argument Clinic (python#104503)pythongh-104482: Fix error handling bugs in ast.c (python#104483)pythongh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization (pythongh-104437)pythonGH-102613: Fix recursion error from `pathlib.Path.glob()` (pythonGH-104373)