NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

gh-91896: Fixup some docs issues following ByteString deprecation#104422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

AlexWaygood merged 2 commits intopython:mainfromAlexWaygood:more-bytestring-deprecations

May 12, 2023

Merged

gh-91896: Fixup some docs issues following ByteString deprecation#104422

AlexWaygood merged 2 commits intopython:mainfromAlexWaygood:more-bytestring-deprecations

May 12, 2023

Conversation

Copy link

Member

AlexWaygood commentedMay 12, 2023•
edited
Loading

Get the doctests forcollections.abc working again (seehttps://github.com/python/cpython/actions/runs/4957850824/jobs/8870015699 as an example failure). It was broken bygh-91896: Improve visibility ofByteString deprecation warnings #104294
Explicitly note in whatsnew thattyping.ByteString now causesDeprecationWarnings, as well ascollections.abc.ByteString.

Issue:Deprecate and schedule removal of collections.abc.ByteString and typing.ByteString #91896

📚 Documentation preview 📚:https://cpython-previews--104422.org.readthedocs.build/

pythongh-102500: Fixup some docs issues following ByteString deprecation

efc9106

AlexWaygood added skip news topic-typing 3.12only security fixes labels

May 12, 2023

AlexWaygood requested review fromJelleZijlstra andhauntsaninja

May 12, 2023 14:22

AlexWaygood requested a review fromrhettinger as acode owner

May 12, 2023 14:22

bedevere-bot added the awaiting core review label

May 12, 2023

bedevere-bot mentioned this pull request

May 12, 2023

Implement PEP 688: Making the buffer protocol accessible in Python#102500

Closed

bedevere-bot added the docsDocumentation in the Doc dir label

May 12, 2023

AlexWaygood changed the title~~gh-102500: Fixup some docs issues following ByteString deprecation~~gh-91896: Fixup some docs issues following ByteString deprecation

May 12, 2023

bedevere-bot mentioned this pull request

May 12, 2023

Deprecate and schedule removal of collections.abc.ByteString and typing.ByteString#91896

Closed

JelleZijlstra reviewed

May 12, 2023

View reviewed changes

Doc/whatsnew/3.12.rstShow resolvedHide resolved

Doc/library/collections.abc.rstShow resolvedHide resolved

Update Doc/library/collections.abc.rst

937ce5e

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

JelleZijlstra approved these changes

May 12, 2023

View reviewed changes

Copy link

Member

JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd like to get this merged so we can get CI green, but we should consider whether theimport * case is important enough to drop the warning. This would be annoying:

% ./python.exe -WerrPython 3.12.0a7+ (heads/tvobject-dirty:bc3757969b, May 12 2023, 06:50:26) [Clang 14.0.0 (clang-1400.0.29.202)] on darwinType "help", "copyright", "credits" or "license" for more information.>>> from typing import *Traceback (most recent call last):  File "<stdin>", line 1, in <module>  File "/Users/jelle/py/cpython/Lib/typing.py", line 3328, in __getattr__    warnings._deprecated("typing.ByteString", remove=(3, 14))  File "/Users/jelle/py/cpython/Lib/warnings.py", line 529, in _deprecated    warn(msg, DeprecationWarning, stacklevel=3)DeprecationWarning: 'typing.ByteString' is deprecated and slated for removal in Python 3.14>>>

bedevere-bot added awaiting merge and removed awaiting core review labels

May 12, 2023

AlexWaygood merged commitce4eecf intopython:main

May 12, 2023

bedevere-bot removed the awaiting merge label

May 12, 2023

AlexWaygood mentioned this pull request

May 12, 2023

gh-91896: Revert some very noisy DeprecationWarnings forByteString#104424

Merged

carljm added a commit to carljm/cpython that referenced this pull request

May 12, 2023

Merge branch 'main' into supermon

8efd7c6

* main:pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422)pythonGH-104371: check return value of calling `mv.release` (python#104417)pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416)pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863)pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387)pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403)pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390)pythongh-101819: Prepare _io._IOBase for module state (python#104386)pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414)  Fix refleak in `super_descr_get` (python#104408)pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700)pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294)pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378)pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394)pythongh-104392: Remove _paramspec_tvars from typing (python#104393)pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397)pythongh-99108: Refresh HACL* from upstream (python#104401)pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)