NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

gh-101819: Fix _io clinic input for unused base class method stubs#104418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

erlend-aasland merged 2 commits intopython:mainfromerlend-aasland:isolate-io/fixup-clinic

May 15, 2023

Merged

gh-101819: Fix _io clinic input for unused base class method stubs#104418

erlend-aasland merged 2 commits intopython:mainfromerlend-aasland:isolate-io/fixup-clinic

May 15, 2023

Conversation

Copy link

Contributor

erlend-aasland commentedMay 12, 2023•
edited by bedevere-bot
Loading

When preparing the _io extension module for isolation, many methods were
adapted to Argument Clinic. Some of these used the '*args: object'
signature, which is incorrect. These are now corrected to an exact
signature, and marked unused, since they are stub methods.

Issue:Isolate the_io extension module #101819

pythongh-101819: Fix _io clinic input for unused base class method stubs

b5e7d6e

When preparing the _io extension module for isolation, many methods wereadapted to Argument Clinic. Some of these used the '*args: object'signature, which is incorrect. These are now corrected to an exactsignature, and marked unused, since they are stub methods.

erlend-aasland added the skip news label

May 12, 2023

erlend-aasland requested a review fromvstinner

May 12, 2023 09:09

bedevere-bot added the awaiting core review label

May 12, 2023

bedevere-bot mentioned this pull request

May 12, 2023

Isolate the_io extension module#101819

Closed

erlend-aasland mentioned this pull request

May 12, 2023

gh-104389: Add 'unused' keyword to Argument Clinic C converters#104390

Merged

erlend-aasland requested a review fromkumaraditya303

May 12, 2023 22:14

Merge branch 'main' into isolate-io/fixup-clinic

0cc7156

erlend-aasland merged commitb378d99 intopython:main

May 15, 2023

bedevere-bot removed the awaiting core review label

May 15, 2023

erlend-aasland deleted the isolate-io/fixup-clinic branch

May 15, 2023 11:21

carljm added a commit to carljm/cpython that referenced this pull request

May 15, 2023

Merge branch 'main' into supermon

343867a

* main: (29 commits)pythongh-101819: Fix _io clinic input for unused base class method stubs (python#104418)pythongh-101819: Isolate `_io` (python#101948)  Bump mypy from 1.2.0 to 1.3.0 in /Tools/clinic (python#104501)pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (python#104495)pythongh-104050: Run mypy on `clinic.py` in CI (python#104421)pythongh-104490: Consistently define phony make targets (python#104491)pythongh-67056: document that registering/unregistering an atexit func from within an atexit func is undefined (python#104473)pythongh-104487: PYTHON_FOR_REGEN must be minimum Python 3.10 (python#104488)pythongh-101282: move BOLT config after PGO (pythongh-104493)pythongh-104469 Convert _testcapi/float.c to use AC (pythongh-104470)pythongh-104456: Fix ref leak in _ctypes.COMError (python#104457)pythongh-98539: Make _SSLTransportProtocol.abort() safe to call when closed (python#104474)pythongh-104337: Clarify random.gammavariate doc entry  (python#104410)  Minor improvements to typing docs (python#104465)pythongh-87092: avoid gcc warning on uninitialized struct field in assemble.c (python#104460)pythonGH-71383: IDLE - Document testing subsets of modules (python#104463)pythongh-104454: Fix refleak in AttributeError_reduce (python#104455)pythongh-75710: IDLE - add docstrings and comments to editor module (python#104446)pythongh-91896: Revert some very noisy DeprecationWarnings for `ByteString` (python#104424)  Add a mention of PYTHONBREAKPOINT to breakpoint() docs (python#104430)  ...

carljm added a commit to carljm/cpython that referenced this pull request

May 15, 2023

Merge branch 'main' into cached_property_docs

452d9f5

* main: (204 commits)pythongh-101819: Fix _io clinic input for unused base class method stubs (python#104418)pythongh-101819: Isolate `_io` (python#101948)  Bump mypy from 1.2.0 to 1.3.0 in /Tools/clinic (python#104501)pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (python#104495)pythongh-104050: Run mypy on `clinic.py` in CI (python#104421)pythongh-104490: Consistently define phony make targets (python#104491)pythongh-67056: document that registering/unregistering an atexit func from within an atexit func is undefined (python#104473)pythongh-104487: PYTHON_FOR_REGEN must be minimum Python 3.10 (python#104488)pythongh-101282: move BOLT config after PGO (pythongh-104493)pythongh-104469 Convert _testcapi/float.c to use AC (pythongh-104470)pythongh-104456: Fix ref leak in _ctypes.COMError (python#104457)pythongh-98539: Make _SSLTransportProtocol.abort() safe to call when closed (python#104474)pythongh-104337: Clarify random.gammavariate doc entry  (python#104410)  Minor improvements to typing docs (python#104465)pythongh-87092: avoid gcc warning on uninitialized struct field in assemble.c (python#104460)pythonGH-71383: IDLE - Document testing subsets of modules (python#104463)pythongh-104454: Fix refleak in AttributeError_reduce (python#104455)pythongh-75710: IDLE - add docstrings and comments to editor module (python#104446)pythongh-91896: Revert some very noisy DeprecationWarnings for `ByteString` (python#104424)  Add a mention of PYTHONBREAKPOINT to breakpoint() docs (python#104430)  ...