NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

GH-104371: check return value of calling`mv.release`#104417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kumaraditya303 merged 1 commit intopython:mainfromkumaraditya303:tc

May 12, 2023

Merged

GH-104371: check return value of calling`mv.release`#104417

kumaraditya303 merged 1 commit intopython:mainfromkumaraditya303:tc

May 12, 2023

Conversation

Copy link

Contributor

kumaraditya303 commentedMay 12, 2023•
edited by bedevere-bot
Loading

Issue:PEP 688: Crash if__release_buffer__ is called while an exception is active #104371

check call result

3d68e2f

kumaraditya303 requested a review frommarkshannon as acode owner

May 12, 2023 08:14

bedevere-bot added the awaiting core review label

May 12, 2023

bedevere-bot mentioned this pull request

May 12, 2023

PEP 688: Crash if__release_buffer__ is called while an exception is active#104371

Closed

kumaraditya303 mentioned this pull request

May 12, 2023

gh-104371: Fix calls to __release_buffer__ while an exception is active#104378

Merged

kumaraditya303 added the skip news label

May 12, 2023

Copy link

Member

markshannon commentedMay 12, 2023

How canreleasebuffer_call_python() be called with an exception set?
It is astatic function, so we control all the callers.

Copy link

Member

JelleZijlstra commentedMay 12, 2023

It gets called fromPyBuffer_Release for a buffer with a Python__release_buffer__. The test inhttps://github.com/python/cpython/pull/104378/files shows an example.

JelleZijlstra approved these changes

May 12, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

May 12, 2023

kumaraditya303 merged commita052be4 intopython:main

May 12, 2023

bedevere-bot removed the awaiting merge label

May 12, 2023

kumaraditya303 deleted the tc branch

May 12, 2023 12:57

carljm added a commit to carljm/cpython that referenced this pull request

May 12, 2023

Merge branch 'main' into supermon

8efd7c6

* main:pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422)pythonGH-104371: check return value of calling `mv.release` (python#104417)pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416)pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863)pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387)pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403)pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390)pythongh-101819: Prepare _io._IOBase for module state (python#104386)pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414)  Fix refleak in `super_descr_get` (python#104408)pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700)pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294)pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378)pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394)pythongh-104392: Remove _paramspec_tvars from typing (python#104393)pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397)pythongh-99108: Refresh HACL* from upstream (python#104401)pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)