NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-99108: Refresh HACL* from upstream#104401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gpshead merged 2 commits intopython:mainfrommsprotz:protz_sha3

May 11, 2023

Merged

gh-99108: Refresh HACL* from upstream#104401

gpshead merged 2 commits intopython:mainfrommsprotz:protz_sha3

May 11, 2023

Conversation

Copy link

Contributor

msprotz commentedMay 11, 2023•
edited by bedevere-bot
Loading

This PR refreshes the vendored HACL* code with an upstream version. It contains a single fix, which increases the maximum length that can be processed by SHA3. This does not affect correctness of the verified code: the previous version would simply return a "maximum length exceeded" error too soon.

This was previously not covered by the Python testsuite, so I added one for this precisely. (Tests are being added upstream, too.)

@gpshead we should definitely get this in before 3.12

Issue:Replace built-in hashlib with verified implementations from HACL* #99108

msprotz added2 commits

May 11, 2023 13:45

Refresh HACL* from upstream

9d268a0

Companion test

0128cf9

msprotz requested a review fromtiran as acode owner

May 11, 2023 20:56

bedevere-bot added the awaiting review label

May 11, 2023

bedevere-bot mentioned this pull request

May 11, 2023

Replace built-in hashlib with verified implementations from HACL*#99108

Closed

Copy link

ContributorAuthor

msprotz commentedMay 11, 2023

I don't think this warrants a news entry but let me know if you'd like to see one.

msprotz mentioned this pull request

May 11, 2023

Extend the max input length bound for SHA3hacl-star/hacl-star#817

Merged

gpshead added the skip news label

May 11, 2023

gpshead self-assigned this

May 11, 2023

gpshead approved these changes

May 11, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

May 11, 2023

gpsheadenabled auto-merge (squash)

May 11, 2023 21:02

gpshead merged commit7d7dd4c intopython:main

May 11, 2023

bedevere-bot removed the awaiting merge label

May 11, 2023

carljm added a commit to carljm/cpython that referenced this pull request

May 12, 2023

Merge branch 'main' into supermon

8efd7c6

* main:pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422)pythonGH-104371: check return value of calling `mv.release` (python#104417)pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416)pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863)pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387)pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403)pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390)pythongh-101819: Prepare _io._IOBase for module state (python#104386)pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414)  Fix refleak in `super_descr_get` (python#104408)pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700)pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294)pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378)pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394)pythongh-104392: Remove _paramspec_tvars from typing (python#104393)pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397)pythongh-99108: Refresh HACL* from upstream (python#104401)pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)