NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-104392: Remove _paramspec_tvars from typing#104393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JelleZijlstra merged 2 commits intopython:mainfromJelleZijlstra:paramspec-tvars

May 11, 2023

Merged

gh-104392: Remove _paramspec_tvars from typing#104393

JelleZijlstra merged 2 commits intopython:mainfromJelleZijlstra:paramspec-tvars

May 11, 2023

Conversation

Copy link

Member

JelleZijlstra commentedMay 11, 2023•
edited by bedevere-bot
Loading

This does nothing.

Issue:_paramspec_tvars in typing.py does nothing #104392

pythongh-104392: Remove _paramspec_tvars from typing

d023d87

This does nothing.

JelleZijlstra requested review fromgvanrossum,Fidget-Spinner andAlexWaygood ascode owners

May 11, 2023 14:49

bedevere-bot added the awaiting core review label

May 11, 2023

bedevere-bot mentioned this pull request

May 11, 2023

_paramspec_tvars in typing.py does nothing#104392

Closed

blurb

f6b0845

Fidget-Spinner approved these changes

May 11, 2023

View reviewed changes

Copy link

Member

Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Considering all tests pass, this LGTM. I'm curious though, when was it loosened? Was it the addition of TypeVarTuple?

bedevere-bot added awaiting merge and removed awaiting core review labels

May 11, 2023

AlexWaygood approved these changes

May 11, 2023

View reviewed changes

Copy link

Member

AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I tried digging into the history around this, but quickly got lost. Whatever the case, as Ken says: all tests pass, so this attribute is clearly currently useless. LGTM :)

JelleZijlstra merged commit37a5d25 intopython:main

May 11, 2023

bedevere-bot removed the awaiting merge label

May 11, 2023

JelleZijlstra deleted the paramspec-tvars branch

May 11, 2023 23:41

carljm added a commit to carljm/cpython that referenced this pull request

May 12, 2023

Merge branch 'main' into supermon

8efd7c6

* main:pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422)pythonGH-104371: check return value of calling `mv.release` (python#104417)pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416)pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863)pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387)pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403)pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390)pythongh-101819: Prepare _io._IOBase for module state (python#104386)pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414)  Fix refleak in `super_descr_get` (python#104408)pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700)pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294)pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378)pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394)pythongh-104392: Remove _paramspec_tvars from typing (python#104393)pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397)pythongh-99108: Refresh HACL* from upstream (python#104401)pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)