Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-103082: Filter LINE events in VM, to simplify tool implementation.#104387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

markshannon
Copy link
Member

@markshannonmarkshannon commentedMay 11, 2023•
edited by bedevere-bot
Loading

When monitoring LINE events, instrument all instructions that can have a predecessor on a different line.
Then check that the a new line has been hit in the instrumentation code.
This brings the behavior closer to that of 3.11, simplifying implementation and porting of tools.

Fixes#103471
Fixes#104239

When monitoring LINE events, instrument all instructions that can have a predecessor on a different line.Then check that the a new line has been hit in the instrumentation code.This brings the behavior closer to that of 3.11, simplifying implementation and porting of tools.
Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Okay, I feel like I have a pretty good grasp of what's going on here, and it looks good.

Just a couple of suggestions where you might add some comments in areas I struggled to finally understand, as well as a couple of questions to clarify some things I couldn't figure out:

@markshannonmarkshannon added the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelMay 12, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@markshannon for commitf9cf3db 🤖

If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelMay 12, 2023
@markshannon
Copy link
MemberAuthor

The failure onRHEL7 Refleaks PR also appears on main.

$ ./python -m test -R 3:3 test_typing0:00:00 load avg: 1.97 Run tests sequentially0:00:00 load avg: 1.97 [1/1] test_typingbeginning 6 repetitions123456.test test_typing failed -- Traceback (most recent call last):  File "/home/mark/cpython/Lib/test/test_typing.py", line 6007, in test_bytestring    with self.assertWarns(DeprecationWarning):AssertionError: DeprecationWarning not triggeredtest_typing failed (1 failure)== Tests result: FAILURE ==1 test failed:    test_typingTotal duration: 546 msTests result: FAILURE

The doc test failure is also unrelated, I think.

@markshannonmarkshannon merged commit45f5aa8 intopython:mainMay 12, 2023
@markshannonmarkshannon deleted the instrument-all-possible-lines branchMay 12, 2023 11:21
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Debian root 3.x has failed when building commit45f5aa8.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/4764) and take a look at the build logs.
  4. Check if the failure is related to this commit (45f5aa8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/4764

Failed tests:

  • test__xxsubinterpreters

Summary of the results of the build (if available):

==

Click to see traceback logs
remote:Enumerating objects: 60, done.remote:Counting objects:   1% (1/60)remote:Counting objects:   3% (2/60)remote:Counting objects:   5% (3/60)remote:Counting objects:   6% (4/60)remote:Counting objects:   8% (5/60)remote:Counting objects:  10% (6/60)remote:Counting objects:  11% (7/60)remote:Counting objects:  13% (8/60)remote:Counting objects:  15% (9/60)remote:Counting objects:  16% (10/60)remote:Counting objects:  18% (11/60)remote:Counting objects:  20% (12/60)remote:Counting objects:  21% (13/60)remote:Counting objects:  23% (14/60)remote:Counting objects:  25% (15/60)remote:Counting objects:  26% (16/60)remote:Counting objects:  28% (17/60)remote:Counting objects:  30% (18/60)remote:Counting objects:  31% (19/60)remote:Counting objects:  33% (20/60)remote:Counting objects:  35% (21/60)remote:Counting objects:  36% (22/60)remote:Counting objects:  38% (23/60)remote:Counting objects:  40% (24/60)remote:Counting objects:  41% (25/60)remote:Counting objects:  43% (26/60)remote:Counting objects:  45% (27/60)remote:Counting objects:  46% (28/60)remote:Counting objects:  48% (29/60)remote:Counting objects:  50% (30/60)remote:Counting objects:  51% (31/60)remote:Counting objects:  53% (32/60)remote:Counting objects:  55% (33/60)remote:Counting objects:  56% (34/60)remote:Counting objects:  58% (35/60)remote:Counting objects:  60% (36/60)remote:Counting objects:  61% (37/60)remote:Counting objects:  63% (38/60)remote:Counting objects:  65% (39/60)remote:Counting objects:  66% (40/60)remote:Counting objects:  68% (41/60)remote:Counting objects:  70% (42/60)remote:Counting objects:  71% (43/60)remote:Counting objects:  73% (44/60)remote:Counting objects:  75% (45/60)remote:Counting objects:  76% (46/60)remote:Counting objects:  78% (47/60)remote:Counting objects:  80% (48/60)remote:Counting objects:  81% (49/60)remote:Counting objects:  83% (50/60)remote:Counting objects:  85% (51/60)remote:Counting objects:  86% (52/60)remote:Counting objects:  88% (53/60)remote:Counting objects:  90% (54/60)remote:Counting objects:  91% (55/60)remote:Counting objects:  93% (56/60)remote:Counting objects:  95% (57/60)remote:Counting objects:  96% (58/60)remote:Counting objects:  98% (59/60)remote:Counting objects: 100% (60/60)remote:Counting objects: 100% (60/60), done.remote:Compressing objects:   3% (1/29)remote:Compressing objects:   6% (2/29)remote:Compressing objects:  10% (3/29)remote:Compressing objects:  13% (4/29)remote:Compressing objects:  17% (5/29)remote:Compressing objects:  20% (6/29)remote:Compressing objects:  24% (7/29)remote:Compressing objects:  27% (8/29)remote:Compressing objects:  31% (9/29)remote:Compressing objects:  34% (10/29)remote:Compressing objects:  37% (11/29)remote:Compressing objects:  41% (12/29)remote:Compressing objects:  44% (13/29)remote:Compressing objects:  48% (14/29)remote:Compressing objects:  51% (15/29)remote:Compressing objects:  55% (16/29)remote:Compressing objects:  58% (17/29)remote:Compressing objects:  62% (18/29)remote:Compressing objects:  65% (19/29)remote:Compressing objects:  68% (20/29)remote:Compressing objects:  72% (21/29)remote:Compressing objects:  75% (22/29)remote:Compressing objects:  79% (23/29)remote:Compressing objects:  82% (24/29)remote:Compressing objects:  86% (25/29)remote:Compressing objects:  89% (26/29)remote:Compressing objects:  93% (27/29)remote:Compressing objects:  96% (28/29)remote:Compressing objects: 100% (29/29)remote:Compressing objects: 100% (29/29), done.remote:Total 31 (delta 29), reused 3 (delta 2), pack-reused 0From https://github.com/python/cpython * branch                  main       -> FETCH_HEADNote:switching to '45f5aa8fc73acf516071d52ef8213532f0381316'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 45f5aa8fc7 GH-103082: Filter LINE events in VM, to simplify tool implementation. (GH-104387)Switched to and reset branch 'main'configure:WARNING: pkg-config is missing. Some dependencies may not be detected correctly.Fatal Python error: drop_gil: PyMUTEX_LOCK(gil->switch_mutex) failedPython runtime state: initializedThread 0x00007f090e821280 (most recent call first):  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 80 in clean_up_interpreters  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 88 in tearDown  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 594 in _callTearDown  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 637 in run  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 690 in __call__  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line 240 in run  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1106 in _run_suite  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1232 in run_unittest  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 294 in _test_module  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 330 in _runtest_inner2  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 373 in _runtest_inner  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 248 in _runtest  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 278 in runtest  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 365 in rerun_failed_tests  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 783 in _main  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 738 in main  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 802 in main  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/__main__.py", line 2 in <module>  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line 88 in _run_code  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line 198 in _run_module_as_mainFatal Python error: AbortedThread 0x00007f090e821280 (most recent call first):  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 80 in clean_up_interpreters  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 88 in tearDown  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 594 in _callTearDown  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 637 in run  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 690 in __call__  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line 240 in run  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1106 in _run_suite  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1232 in run_unittest  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 294 in _test_module  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 330 in _runtest_inner2  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 373 in _runtest_inner  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 248 in _runtest  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 278 in runtest  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 365 in rerun_failed_tests  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 783 in _main  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 738 in main  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 802 in main  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/__main__.py", line 2 in <module>  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line 88 in _run_code  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line 198 in _run_module_as_mainExtension modules: _testcapi, _xxsubinterpreters (total: 2)Abortedmake:*** [Makefile:1956: buildbottest] Error 134Cannot open file '/root/buildarea/3.x.angelico-debian-amd64/build/test-results.xml' for upload

carljm added a commit to carljm/cpython that referenced this pull requestMay 12, 2023
* main:pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422)pythonGH-104371: check return value of calling `mv.release` (python#104417)pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416)pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863)pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387)pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403)pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390)pythongh-101819: Prepare _io._IOBase for module state (python#104386)pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414)  Fix refleak in `super_descr_get` (python#104408)pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700)pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294)pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378)pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394)pythongh-104392: Remove _paramspec_tvars from typing (python#104393)pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397)pythongh-99108: Refresh HACL* from upstream (python#104401)pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@brandtbucherbrandtbucherbrandtbucher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@markshannon@bedevere-bot@brandtbucher
[8]ページ先頭
©2009-2025 Movatter.jp