Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-102613: Fix recursion error frompathlib.Path.glob()#104373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@barneygale
Copy link
Contributor

@barneygalebarneygale commentedMay 11, 2023•
edited by bedevere-bot
Loading

UsePath.walk() to implement the recursive wildcard**. This method uses an iterative (rather than recursive) walk - seeGH-100282.

Use `Path.walk()` to implement the recursive wildcard `**`. This methoduses an iterative (rather than recursive) walk - seepythonGH-100282.
@barneygale
Copy link
ContributorAuthor

This won't backport to 3.11, asPath.walk() is new in 3.12.

@barneygale
Copy link
ContributorAuthor

@Ovsyanka83 would you like to review, if you have a mo? Uses your shinywalk() method! :)

@zmievsa
Copy link
Contributor

Will take a look on saturday! :)

barneygale reacted with heart emoji

Copy link
Contributor

@zmievsazmievsa left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for using our work here! Every time "walk" gets used or mentioned, it makes me feel really nice and like my work has made a difference :D

I like the ideas and have a few suggestions here and there -- your logic feels quite right and my changes are doubtful and mostly stylistic :)

barneygale reacted with thumbs up emoji
Copy link
Contributor

@zmievsazmievsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

After your replies the logic itself makes much more sense so I'm ready to approve this.

barneygale reacted with heart emoji
@barneygale
Copy link
ContributorAuthor

Thank you!

@barneygale
Copy link
ContributorAuthor

Hey@carljm, would you be up for reviewing this? You reviewed#100282 which madePath.walk() iterative; it's that work I'm exploiting here. No worries if not, thank you!

Copy link
Member

@carljmcarljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good to me, apart from the one inline comment, which could be addressed as a follow-up also.

@barneygalebarneygale merged commitcb88ae6 intopython:mainMay 15, 2023
carljm added a commit to carljm/cpython that referenced this pull requestMay 16, 2023
* main:pythonGH-104510: Fix refleaks in `_io` base types (python#104516)pythongh-104539: Fix indentation error in logging.config.rst (python#104545)pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543)pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538)pythongh-64595: Fix write file logic in Argument Clinic (python#104507)pythongh-104523: Inline minimal PGO rules (python#104524)pythongh-103861: Fix Zip64 extensions not being properly applied in some cases (python#103863)pythongh-69152: add method get_proxy_response_headers to HTTPConnection class (python#104248)pythongh-103763: Implement PEP 695 (python#103764)pythongh-104461: Run tkinter test_configure_screen on X11 only (pythonGH-104462)pythongh-104469: Convert _testcapi/watchers.c to use Argument Clinic (python#104503)pythongh-104482: Fix error handling bugs in ast.c (python#104483)pythongh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization (pythongh-104437)pythonGH-102613: Fix recursion error from `pathlib.Path.glob()` (pythonGH-104373)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood left review comments

@carljmcarljmcarljm approved these changes

+1 more reviewer

@zmievsazmievsazmievsa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@barneygale@zmievsa@carljm@AlexWaygood@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp