NotificationsYou must be signed in to change notification settings
Fork32k
Star67.2k

gh-101819: Clean up _io windows console io after gh-104197#104354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

erlend-aasland merged 2 commits intopython:mainfromerlend-aasland:isolate-io/fixup-win

May 10, 2023

Merged

gh-101819: Clean up _io windows console io after gh-104197#104354

erlend-aasland merged 2 commits intopython:mainfromerlend-aasland:isolate-io/fixup-win

May 10, 2023

Conversation

Copy link

Contributor

erlend-aasland commentedMay 10, 2023•
edited by bedevere-bot
Loading

Issue:Isolate the_io extension module #101819

erlend-aasland added2 commits

May 10, 2023 12:32

Use HAVE_WINDOWS_CONSOLE_IO where appropriate

ea1ae76

Address Victor's review ofpythongh-104197

725e784

erlend-aasland added the skip news label

May 10, 2023

erlend-aasland requested a review fromvstinner

May 10, 2023 10:34

bedevere-bot mentioned this pull request

May 10, 2023

Isolate the_io extension module#101819

Closed

bedevere-bot added the awaiting core review label

May 10, 2023

kumaraditya303 approved these changes

May 10, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

May 10, 2023

erlend-aaslandenabled auto-merge (squash)

May 10, 2023 10:41

erlend-aasland merged commit2dcb289 intopython:main

May 10, 2023

bedevere-bot removed the awaiting merge label

May 10, 2023

erlend-aasland deleted the isolate-io/fixup-win branch

May 10, 2023 10:59

carljm added a commit to carljm/cpython that referenced this pull request

May 10, 2023

Merge branch 'main' into fixloadsuperspec

5976df9

* main:pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182)pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364)pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539)pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292)pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202)pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013)pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355)pythongh-103960: Dark mode: invert image brightness (python#103983)pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253)pythongh-101819: Clean up _io windows console io afterpythongh-104197 (python#104354)pythongh-101819: Harden _io init (python#104352)pythongh-103247: clear the module cache in a test in test_importlib/extensions/test_loader.py (pythonGH-104226)pythongh-103848: Adds checks to ensure that bracketed hosts found by urlsplit are of IPv6 or IPvFuture format (python#103849)pythongh-74895: adjust tests to work on Solaris (python#104326)pythongh-101819: Refactor _io in preparation for module isolation (python#104334)pythongh-90953: Don't use deprecated AST nodes in clinic.py (python#104322)pythongh-102327: Extend docs for "url" and "headers" parameters to HTTPConnection.request()pythongh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (python#104335)

carljm added a commit to carljm/cpython that referenced this pull request

May 11, 2023

Merge branch 'main' into supermon

19b3d9e

* main: (27 commits)pythongh-87849: fix SEND specialization family definition (pythonGH-104268)pythongh-101819: Adapt _io.IOBase.seek and _io.IOBase.truncate to Argument Clinic (python#104384)pythongh-101819: Adapt _io._Buffered* methods to Argument Clinic (python#104367)pythongh-101819: Refactor `_io` futher in preparation for module isolation (python#104369)pythongh-101819: Adapt _io.TextIOBase methods to Argument Clinic (python#104383)pythongh-101117: Improve accuracy of sqlite3.Cursor.rowcount docs (python#104287)pythonGH-92184: Convert os.altsep to '/' in filenames when creating ZipInfo objects (python#92185)pythongh-104357: fix inlined comprehensions that close over iteration var (python#104368)pythonGH-90208: Suppress OSError exceptions from `pathlib.Path.glob()` (pythonGH-104141)pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182)pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364)pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539)pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292)pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202)pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013)pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355)pythongh-103960: Dark mode: invert image brightness (python#103983)pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253)pythongh-101819: Clean up _io windows console io afterpythongh-104197 (python#104354)pythongh-101819: Harden _io init (python#104352)  ...