Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104301: Allow leading whitespace in disambiguated pdb statements#104342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

SnoopJ
Copy link
Contributor

@SnoopJSnoopJ commentedMay 9, 2023•
edited by github-actionsbot
Loading

This changesetfixes#104301 by allowing leading whitespace in statements prefixed by! inpdb, as an alternate to#104302, suggestedhere.

This PR also adds a corresponding example of thepdb documentation.

📚 Documentation preview 📚:https://cpython-previews--104342.org.readthedocs.build/

@iritkatriel
Copy link
Member

Do we have tests for this feature?

@gaogaotiantian
Copy link
Member

Ah right, totally forgot about that.@SnoopJ could you add some test case to use! with spaces? The doctests intest_pdb.py should not be too hard to follow, let me know if you have any questions.

@SnoopJ
Copy link
ContributorAuthor

No problem, added inebf179d. I couldn't find any pre-existing tests of the feature, so let me know if the test I added should also explicitly test the spelling without any leading whitespace

SnoopJand others added2 commitsMay 11, 2023 11:22
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@SnoopJSnoopJforce-pushed thegh-104301_pdb-allow-leading-statement-whitespace branch from84ad82a to778a4efCompareMay 11, 2023 15:25
@SnoopJ
Copy link
ContributorAuthor

Sorry about the force-push, I wanted to be sure that theCo-authored-by attribution was present since I didn't use the suggestion UI to make that change.

@iritkatrieliritkatriel added type-featureA feature request or enhancement stdlibPython modules in the Lib dir labelsMay 11, 2023
@iritkatriel
Copy link
Member

Sorry about the force-push, I wanted to be sure that theCo-authored-by attribution was present since I didn't use the suggestion UI to make that change.

There's no need for it (minor code review suggestions do not typically need to imply coauthorship).

SnoopJ reacted with thumbs up emoji

@iritkatriel
Copy link
Member

there's a test failure

@iritkatrieliritkatriel merged commit0449ffe intopython:mainMay 11, 2023
@SnoopJSnoopJ deleted the gh-104301_pdb-allow-leading-statement-whitespace branchMay 11, 2023 17:18
carljm added a commit to carljm/cpython that referenced this pull requestMay 12, 2023
* main:pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422)pythonGH-104371: check return value of calling `mv.release` (python#104417)pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416)pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863)pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387)pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403)pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390)pythongh-101819: Prepare _io._IOBase for module state (python#104386)pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414)  Fix refleak in `super_descr_get` (python#104408)pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700)pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294)pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378)pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394)pythongh-104392: Remove _paramspec_tvars from typing (python#104393)pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397)pythongh-99108: Refresh HACL* from upstream (python#104401)pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

@gaogaotiantiangaogaotiantiangaogaotiantian approved these changes

Assignees
No one assigned
Labels
stdlibPython modules in the Lib dirtype-featureA feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misleading documentation of! prefix inpdb
4 participants
@SnoopJ@iritkatriel@gaogaotiantian@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp