Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-74895: adjust tests to work on Solaris#104326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 1 commit intopython:mainfromkulikjak:getaddrinfo-test-fix
May 9, 2023

Conversation

kulikjak
Copy link
Contributor

@kulikjakkulikjak commentedMay 9, 2023
edited by bedevere-bot
Loading

This change adjusts tests introduced in#2435 such that they work on platforms wheresocket.getaddrinfo(None, port) doesn't end with success; however, it does so whensocket.SOCK_STREAM is present.

I am aware only of Solaris that works this way, but it's still well within the standard (if not"more correct").

All other tests callinggetaddrinfo(None, ....) includesocket.SOCK_STREAM as well, and the addition doesn't change at all the thing the test is testing, so hopefully, this is acceptable.

(can I reuse the original issue for an additional commit?)

@bedevere-botbedevere-bot added awaiting review testsTests in the Lib/test dir labelsMay 9, 2023
@kulikjak
Copy link
ContributorAuthor

@gpshead (as you recently merged the original change)

@gpsheadgpshead self-assigned thisMay 9, 2023
@gpsheadgpshead added the needs backport to 3.11only security fixes labelMay 9, 2023
@gpsheadgpshead merged commit2c863b3 intopython:mainMay 9, 2023
@miss-islington
Copy link
Contributor

Thanks@kulikjak for the PR, and@gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@kulikjak and@gpshead, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 2c863b3871c6127a80aa7229033219f1cdcc8711 3.11

@kulikjak
Copy link
ContributorAuthor

Thank you!

carljm added a commit to carljm/cpython that referenced this pull requestMay 10, 2023
* main:pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182)pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364)pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539)pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292)pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202)pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013)pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355)pythongh-103960: Dark mode: invert image brightness (python#103983)pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253)pythongh-101819: Clean up _io windows console io afterpythongh-104197 (python#104354)pythongh-101819: Harden _io init (python#104352)pythongh-103247: clear the module cache in a test in test_importlib/extensions/test_loader.py (pythonGH-104226)pythongh-103848: Adds checks to ensure that bracketed hosts found by urlsplit are of IPv6 or IPvFuture format (python#103849)pythongh-74895: adjust tests to work on Solaris (python#104326)pythongh-101819: Refactor _io in preparation for module isolation (python#104334)pythongh-90953: Don't use deprecated AST nodes in clinic.py (python#104322)pythongh-102327: Extend docs for "url" and "headers" parameters to HTTPConnection.request()pythongh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (python#104335)
@gpsheadgpshead added needs backport to 3.11only security fixes and removed needs backport to 3.11only security fixes labelsMay 11, 2023
@miss-islington
Copy link
Contributor

Thanks@kulikjak for the PR, and@gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@kulikjak and@gpshead, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 2c863b3871c6127a80aa7229033219f1cdcc8711 3.11

@ZeroIntensityZeroIntensity removed the needs backport to 3.11only security fixes labelFeb 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@gpsheadgpshead

Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@kulikjak@miss-islington@gpshead@bedevere-bot@ZeroIntensity

[8]ページ先頭

©2009-2025 Movatter.jp