Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-102500: Remove mention of bytes shorthand#104281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The bytes shorthand was removed in PEP 688:https://peps.python.org/pep-0688/#no-special-meaning-for-bytesI also remove the reference to `collections.abc.ByteString`, since thatobject is deprecated (python#91896) and has different semantics (python#102092)I think it would be good to backport this since the changes in the typesystem are immediate and apply to all versions of Python.
JelleZijlstra approved these changesMay 8, 2023
Thanks@hauntsaninja for the PR, and@AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry@hauntsaninja and@AlexWaygood, I had trouble checking out the |
Thanks@hauntsaninja for the PR, and@AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry,@hauntsaninja and@AlexWaygood, I could not cleanly backport this to |
bedevere-bot commentedMay 8, 2023
GH-104288 is a backport of this pull request to the3.11 branch. |
AlexWaygood pushed a commit to AlexWaygood/cpython that referenced this pull requestMay 8, 2023
The bytes shorthand was removed in PEP 688:https://peps.python.org/pep-0688/#no-special-meaning-for-bytesI also remove the reference to `collections.abc.ByteString`, since thatobject is deprecated (python#91896) and has different semantics (python#102092)
AlexWaygood added a commit that referenced this pull requestMay 8, 2023
gh-102500: Remove mention of bytes shorthand (#104281)The bytes shorthand was removed in PEP 688:https://peps.python.org/pep-0688/#no-special-meaning-for-bytesThe reference to collections.abc.ByteString is also removed, since that object is deprecated (#91896) and has different semantics (#102092)Although PEP 688 is new in Python 3.12, type checkers are expected to implement the new semantics for type annotations even if users are using an older version of Python, so this docs PR is backported to Python 3.11.Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull requestMay 8, 2023
The bytes shorthand was removed in PEP 688:https://peps.python.org/pep-0688/#no-special-meaning-for-bytesI also remove the reference to `collections.abc.ByteString`, since thatobject is deprecated (python#91896) and has different semantics (python#102092)
carljm added a commit to carljm/cpython that referenced this pull requestMay 9, 2023
* main: (47 commits)pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)pythonGH-104284: Fix documentation gettext build (python#104296)pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)pythongh-99108: fix typo in Modules/Setup (python#104293)pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172)pythongh-103193: Improve `getattr_static` test coverage (python#104286) Trim trailing whitespace and test on CI (python#104275)pythongh-102500: Remove mention of bytes shorthand (python#104281)pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256)pythongh-99108: Replace SHA3 implementation HACL* version (python#103597)pythongh-104273: Remove redundant len() calls in argparse function (python#104274)pythongh-64660: Don't hardcode Argument Clinic return converter result variable name (python#104200)pythongh-104265 Disallow instantiation of `_csv.Reader` and `_csv.Writer` (python#104266)pythonGH-102613: Improve performance of `pathlib.Path.rglob()` (pythonGH-104244)pythongh-103650: Fix perf maps address format (python#103651)pythonGH-89812: Churn `pathlib.Path` methods (pythonGH-104243) ...
carljm added a commit to carljm/cpython that referenced this pull requestMay 9, 2023
* main: (29 commits)pythongh-104276: Make `_struct.unpack_iterator` type use type flag instead of custom constructor (python#104277)pythongh-97696: Move around and update the whatsnew entry for asyncio eager task factory (python#104298)pythongh-103193: Fix refleaks in `test_inspect` and `test_typing` (python#104320) require-pr-label.yml: Add missing "permissions:" (python#104309)pythongh-90656: Add platform triplets for 64-bit LoongArch (LA64) (python#30939)pythongh-104180: Read SOCKS proxies from macOS System Configuration (python#104181)pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)pythonGH-104284: Fix documentation gettext build (python#104296)pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)pythongh-99108: fix typo in Modules/Setup (python#104293)pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172)pythongh-103193: Improve `getattr_static` test coverage (python#104286) Trim trailing whitespace and test on CI (python#104275)pythongh-102500: Remove mention of bytes shorthand (python#104281)pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256)pythongh-99108: Replace SHA3 implementation HACL* version (python#103597) ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The bytes shorthand was removed in PEP 688:
https://peps.python.org/pep-0688/#no-special-meaning-for-bytes
I also remove the reference to
collections.abc.ByteString, since that object is also deprecated (#91896) and has different semantics from those documented fortyping.ByteString(#102092).I've documented the removal timeline as matching that of
collections.abc.ByteString, but I'm open to discussion on that point.I think it would be good to backport this since the changes in the type system are immediate and apply to all versions of Python.
📚 Documentation preview 📚:https://cpython-previews--104281.org.readthedocs.build/