Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
Trim trailing whitespace and test on CI#104275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Nice, I like this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Will this check for missing\n or multiple\ns at the end of a file?
Uh oh!
There was an error while loading.Please reload this page.
No, but if we also added the https://github.com/pre-commit/pre-commit-hooks#end-of-file-fixer |
ezio-melotti approved these changesMay 7, 2023
Member
ezio-melotti left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The PR looks ok, but doesn'tpatchcheck already check for trailing whitespace?
Are these old files that haven't been touched sincepatchcheck was added so they never got fixed (iircpatchcheck only checks modified files)?
Member
terryjreedy commentedMay 8, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
According to the experiment I just ran, patchcheck does not notice or fix end-of-file issues. To be clear, I think that they should be fixed. Currently, GH comments on missing \n but does not fix. I believe this is meant to eventually replace the patchcheck that is part of the non-required Pipelines run. |
That fixes 524 files... Details$pre-commit run --all-filescheck yaml...............................................................Passedfix end of files.........................................................Failed- hook id: end-of-file-fixer- exit code: 1- files were modified by this hookFixing PCbuild/_asyncio.vcxproj.filtersFixing Lib/test/cjkencodings/euc_jp.txtFixing Doc/tools/templates/search.htmlFixing Doc/library/shelve.rstFixing Lib/test/xmltestdata/c14n-20/out_inNsXml_c14nPrefixQname.xmlFixing PCbuild/_sqlite3.vcxproj.filtersFixing Lib/test/xmltestdata/c14n-20/c14nComment.xmlFixing Modules/unicodedata_db.hFixing Lib/test/decimaltestdata/dqMax.decTestFixing Python/suggestions.cFixing Tools/msi/exe/exe_d.wixprojFixing Doc/howto/urllib2.rstFixing Lib/test/xmltestdata/c14n-20/c14nDefault.xmlFixing Include/pyexpat.hFixing Doc/whatsnew/2.5.rstFixing Lib/test/decimaltestdata/rounding.decTestFixing PCbuild/tk.vcxprojFixing Lib/test/decimaltestdata/inexact.decTestFixing Doc/library/termios.rstFixing Doc/whatsnew/2.2.rstFixing Lib/test/test_tomllib/data/valid/hex-char.tomlFixing Modules/_hacl/Hacl_Hash_MD5.cFixing Tools/buildbot/buildmsi.batFixing Lib/test/cjkencodings/big5-utf8.txtFixing Lib/test/decimaltestdata/dqCopySign.decTestFixing Objects/stringlib/find_max_char.hFixing Lib/test/test_email/data/msg_22.txtFixing Lib/test/cjkencodings/shift_jis.txtFixing Lib/test/xmltestdata/c14n-20/c14nQnameXpathElem.xmlFixing Lib/test/test_tomllib/data/invalid/boolean/invalid-true-casing.tomlFixing Objects/stringlib/partition.hFixing Lib/test/xmltestdata/c14n-20/out_inNsContent_c14nDefault.xmlFixing Lib/test/decimaltestdata/tointegral.decTestFixing Lib/test/xmltestdata/c14n-20/out_inNsSuperfluous_c14nPrefix.xmlFixing PCbuild/_ctypes.vcxproj.filtersFixing Doc/tutorial/whatnow.rstFixing Mac/BuildScript/scripts/postflight.documentationFixing Doc/library/filecmp.rstFixing Lib/test/test_email/data/msg_36.txtFixing Lib/test/decimaltestdata/dqMultiply.decTestFixing PCbuild/_queue.vcxproj.filtersFixing Lib/test/decimaltestdata/dqToIntegral.decTestFixing Lib/test/test_tomllib/data/invalid/multiline-literal-str/file-ends-after-opening.tomlFixing Tools/msi/appendpath/appendpath.wxsFixing Lib/test/decimaltestdata/ddDivide.decTestFixing Lib/test/xmltestdata/c14n-20/world.txtFixing Lib/test/decimaltestdata/decQuad.decTestFixing Tools/msi/sdktools.psm1Fixing Tools/stringbench/READMEFixing Python/symtable.cFixing PCbuild/tcl.vcxprojFixing Tools/msi/bundle/packagegroups/dev.wxsFixing PCbuild/_ctypes_test.vcxprojFixing Lib/test/test_email/data/msg_25.txtFixing Lib/test/test_tomllib/data/invalid/inline-table/define-twice-in-subtable.tomlFixing PC/icons/launcher.svgFixing Doc/library/mailcap.rstFixing Misc/coverity_model.cFixing Lib/test/keycert.passwd.pemFixing Lib/test/xmltestdata/test.xml.outFixing Tools/msi/tcltk/tcltk_pdb.wixprojFixing Modules/_blake2/impl/blake2.hFixing Lib/test/decimaltestdata/dqRemainderNear.decTestFixing Doc/library/imghdr.rstFixing Modules/_decimal/libmpdec/examples/compare.cFixing Doc/library/xml.sax.reader.rstFixing Modules/_testbuffer.cFixing PC/pyshellext.cppFixing Lib/test/xmltestdata/c14n-20/out_inNsPushdown_c14nPrefix.xmlFixing Python/traceback.cFixing Doc/library/stringprep.rstFixing Tools/msi/doc/doc.wixprojFixing Lib/test/decimaltestdata/logb.decTestFixing Lib/test/test_tkinter/READMEFixing PC/icons/pyc.svgFixing PC/store_info.txtFixing PCbuild/pywlauncher.vcxproj.filtersFixing PCbuild/_testconsole.vcxprojFixing Modules/_decimal/libmpdec/examples/shift.cFixing Tools/msi/bundle/packagegroups/tcltk.wxsFixing Lib/test/test_tomllib/data/invalid/keys-and-vals/ends-early-table-def.tomlFixing PCbuild/venvlauncher.vcxproj.filtersFixing Lib/test/xmltestdata/c14n-20/out_inC14N5_c14nTrim.xmlFixing PCbuild/build.batFixing Lib/test/test_tomllib/data/invalid/dotted-keys/access-non-table.tomlFixing Tools/msi/lib/lib_d.wixprojFixing PCbuild/pythonw.vcxprojFixing PCbuild/_tkinter.vcxproj.filtersFixing Modules/_blake2/impl/blake2b-ref.cFixing Objects/stringlib/ucs4lib.hFixing Tools/msi/tcltk/tcltk_d.wixprojFixing Doc/library/heapq.rstFixing Modules/_blake2/impl/blake2s-load-sse41.hFixing Lib/test/tokenize_tests.txtFixing Modules/_decimal/libmpdec/examples/div.cFixing Lib/test/cjkencodings/euc_jp-utf8.txtFixing PCbuild/_socket.vcxproj.filtersFixing Lib/test/decimaltestdata/class.decTestFixing Doc/c-api/objbuffer.rstFixing Doc/library/array.rstFixing Lib/test/decimaltestdata/ddNextToward.decTestFixing Lib/test/decimaltestdata/ddNextMinus.decTestFixing PC/pylauncher.rcFixing PCbuild/_testbuffer.vcxprojFixing Lib/test/decimaltestdata/base.decTestFixing Tools/msi/lib/lib_pdb.wixprojFixing Lib/test/test_tomllib/data/invalid/multiline-basic-str/file-ends-after-opening.tomlFixing PCbuild/_msi.vcxprojFixing Lib/test/decimaltestdata/ddScaleB.decTestFixing Modules/_decimal/README.txtFixing Mac/BuildScript/resources/Conclusion.rtfFixing Lib/test/test_tomllib/data/invalid/inline-table/overwrite-value-in-inner-table.tomlFixing Objects/exceptions.cFixing Lib/test/xmltestdata/c14n-20/out_inNsSort_c14nDefault.xmlFixing Lib/test/xmltestdata/c14n-20/out_inC14N5_c14nDefault.xmlFixing Lib/test/xmltestdata/c14n-20/out_inC14N2_c14nDefault.xmlFixing Lib/test/decimaltestdata/decDouble.decTestFixing Modules/_testimportmultiple.cFixing Doc/library/chunk.rstFixing Lib/test/decimaltestdata/dqMaxMag.decTestFixing Lib/test/test_tomllib/data/invalid/multiline-basic-str/carriage-return.tomlFixing Lib/test/xmltestdata/c14n-20/out_inNsSort_c14nPrefix.xmlFixing Tools/msi/msi.propsFixing Objects/stringlib/split.hFixing Python/pyctype.cFixing Lib/test/test_tomllib/data/invalid/keys-and-vals/no-value.tomlFixing PCbuild/python3dll.vcxproj.filtersFixing Modules/_decimal/libmpdec/literature/bignum.txtFixing Objects/bytesobject.cFixing Tools/msi/pip/pip.wxsFixing Modules/cjkcodecs/mappings_tw.hFixing PCbuild/pythonw_uwp.vcxproj.filtersFixing Doc/copyright.rstFixing Tools/msi/bundle/full.wixprojFixing Doc/howto/sockets.rstFixing Tools/msi/bundle/packagegroups/packageinstall.wxsFixing PCbuild/unicodedata.vcxprojFixing Modules/_decimal/tests/README.txtFixing Objects/stringlib/fastsearch.hFixing Lib/test/cjkencodings/johab-utf8.txtFixing Modules/_blake2/impl/blake2b-load-sse2.hFixing Doc/tutorial/stdlib2.rstFixing Lib/test/cjkencodings/cp949.txtFixing Tools/freeze/test/MakefileFixing Doc/library/turtle-star.psFixing PC/icons/pyd.svgFixing Lib/test/decimaltestdata/nextplus.decTestFixing Tools/msi/README.txtFixing Lib/test/randv2_32.pckFixing Lib/test/test_tomllib/data/invalid/inline-table/overwrite-value-in-inner-array.tomlFixing Tools/msi/test/test_pdb.wixprojFixing Lib/test/test_tomllib/data/invalid/multiline-literal-str/unclosed.tomlFixing PCbuild/pyshellext.vcxproj.filtersFixing PCbuild/openssl.vcxprojFixing PCbuild/libffi.propsFixing Modules/_blake2/impl/blake2s.cFixing Lib/test/decimaltestdata/copysign.decTestFixing Doc/library/zipapp.rstFixing Lib/test/xmltestdata/c14n-20/out_inC14N3_c14nTrim.xmlFixing Lib/test/xmltestdata/c14n-20/c14nPrefix.xmlFixing Doc/library/curses.panel.rstFixing Modules/_decimal/libmpdec/literature/REFERENCES.txtFixing Lib/test/test_tomllib/data/invalid/basic-str-ends-in-escape.tomlFixing Lib/test/test_tomllib/data/invalid/keys-and-vals/only-ws-after-dot.tomlFixing Doc/c-api/init.rstFixing PCbuild/_bz2.vcxproj.filtersFixing Doc/library/xdrlib.rstFixing Lib/test/xmltestdata/c14n-20/out_inC14N4_c14nDefault.xmlFixing Modules/_blake2/impl/blake2b-round.hFixing Lib/test/test_tomllib/data/invalid/inline-table/mutate.tomlFixing Modules/_blake2/impl/blake2s-ref.cFixing Tools/msi/core/core_pdb.wixprojFixing Modules/expat/pyexpatns.hFixing Lib/test/coding20731.pyFixing Tools/msi/lib/lib.wixprojFixing Doc/library/uuid.rstFixing Lib/test/decimaltestdata/testall.decTestFixing Modules/hashlib.hFixing Doc/library/tty.rstFixing Mac/BuildScript/resources/ReadMe.rtfFixing Doc/library/logging.handlers.rstFixing Modules/_decimal/libmpdec/examples/pow.cFixing Modules/_hacl/Hacl_Hash_SHA1.cFixing PCbuild/_ctypes_test.vcxproj.filtersFixing Lib/test/decimaltestdata/dqSameQuantum.decTestFixing PCbuild/pyshellext.vcxprojFixing Lib/test/cjkencodings/gb18030.txtFixing Lib/test/test_email/data/msg_02.txtFixing Modules/_decimal/libmpdec/literature/mulmod-64.txtFixing Doc/library/xml.dom.rstFixing Lib/test/cjkencodings/gbk.txtFixing Doc/c-api/allocation.rstFixing Lib/test/test_email/data/msg_18.txtFixing Modules/_sha3/sha3.hFixing PC/icons/python.svgFixing Python/ceval_gil.cFixing Lib/test/decimaltestdata/ddBase.decTestFixing PCbuild/pyexpat.vcxproj.filtersFixing .github/problem-matchers/sphinx.jsonFixing PCbuild/_testinternalcapi.vcxproj.filtersFixing PCbuild/_testembed.vcxproj.filtersFixing Doc/library/copy.rstFixing Mac/IDLE/IDLE.app/Contents/PkgInfoFixing PCbuild/_multiprocessing.vcxprojFixing Lib/test/decimaltestdata/nextminus.decTestFixing Lib/test/randv3.pckFixing Modules/_decimal/libmpdec/examples/sqrt.cFixing Mac/PythonLauncher/English.lproj/Credits.rtfFixing Tools/msi/bundle/packagegroups/exe.wxsFixing Lib/test/xmltestdata/c14n-20/out_inC14N6_c14nDefault.xmlFixing Lib/test/decimaltestdata/ddRemainderNear.decTestFixing Lib/test/decimaltestdata/ddMultiply.decTestFixing PCbuild/_testcapi.vcxproj.filtersFixing Lib/test/xmltestdata/c14n-20/out_inC14N3_c14nPrefix.xmlFixing PCbuild/prepare_libffi.batFixing Lib/test/decimaltestdata/ddEncode.decTestFixing Mac/PythonLauncher/English.lproj/MainMenu.nib/classes.nibFixing Doc/library/base64.rstFixing Lib/test/xmltestdata/c14n-20/out_inC14N2_c14nTrim.xmlFixing Lib/test/xmltestdata/c14n-20/out_inNsContent_c14nQnameElem.xmlFixing Lib/test/decimaltestdata/minus.decTestFixing Lib/test/xmltestdata/c14n-20/c14nPrefixQnameXpathElem.xmlFixing Tools/msi/pip/pip.wixprojFixing PCbuild/sqlite3.vcxproj.filtersFixing Lib/test/xmltestdata/c14n-20/out_inNsPushdown_c14nDefault.xmlFixing Lib/test/decimaltestdata/dqClass.decTestFixing Lib/test/test_difflib_expect.htmlFixing Lib/test/decimaltestdata/ddCanonical.decTestFixing Lib/test/test_tomllib/data/invalid/multiline-basic-str/unclosed-ends-in-whitespace-escape.tomlFixing Programs/_bootstrap_python.cFixing Include/py_curses.hFixing Lib/test/xmltestdata/c14n-20/c14nQnameElem.xmlFixing Lib/test/test_tomllib/data/invalid/keys-and-vals/ends-early.tomlFixing Doc/library/socketserver.rstFixing Lib/test/ziptestdata/README.mdFixing Objects/unicodetype_db.hFixing Tools/msi/bundle/releaselocal.wixprojFixing Lib/test/test_tomllib/data/invalid/invalid-comment-char.tomlFixing Modules/_sha3/sha3.cFixing Lib/test/cjkencodings/gb18030-utf8.txtFixing Lib/test/decimaltestdata/decSingle.decTestFixing Tools/unicode/python-mappings/gb-18030-2000.xmlFixing Lib/test/test_email/data/msg_15.txtFixing Tools/msi/path/path.wixprojFixing Lib/test/decimaltestdata/divide.decTestFixing Lib/test/decimaltestdata/dqNextToward.decTestFixing .github/problem-matchers/msvc.jsonFixing Tools/msi/msi.targetsFixing Tools/msi/launcher/launcher.wixprojFixing Lib/test/randv2_64.pckFixing Include/internal/pycore_blocks_output_buffer.hFixing PCbuild/_elementtree.vcxproj.filtersFixing Doc/whatsnew/2.6.rstFixing Lib/test/test_importlib/resources/data02/subdirectory/subsubdir/resource.txtFixing Doc/library/rlcompleter.rstFixing Tools/msi/bundle/packagegroups/launcher.wxsFixing PCbuild/_testbuffer.vcxproj.filtersFixing Lib/test/decimaltestdata/remainder.decTestFixing Lib/test/test_tomllib/data/valid/boolean.tomlFixing Lib/test/test_zoneinfo/data/zoneinfo_data.jsonFixing Programs/_freeze_module.cFixing Lib/test/decimaltestdata/ddRemainder.decTestFixing Lib/test/cjkencodings/shift_jis-utf8.txtFixing Doc/library/email.encoders.rstFixing Tools/msi/core/core_d.wixprojFixing Doc/library/audioop.rstFixing Tools/msi/bundle/packagegroups/doc.wxsFixing Tools/msi/path/path.wxsFixing Doc/library/urllib.error.rstFixing Doc/c-api/intro.rstFixing Doc/library/marshal.rstFixing Modules/_decimal/libmpdec/examples/powmod.cFixing Lib/test/cjkencodings/gb2312.txtFixing Doc/library/aifc.rstFixing Lib/test/xmltestdata/c14n-20/out_inNsXml_c14nQname.xmlFixing PCbuild/xxlimited.vcxproj.filtersFixing Lib/test/xmltestdata/c14n-20/out_inNsDefault_c14nDefault.xmlFixing PCbuild/_zoneinfo.vcxproj.filtersFixing Lib/test/decimaltestdata/max.decTestFixing Lib/test/decimaltestdata/plus.decTestFixing Lib/test/decimaltestdata/dqFMA.decTestFixing Lib/test/test_tomllib/data/invalid/inline-table/file-end-after-key-val.tomlFixing PCbuild/_tkinter.vcxprojFixing Objects/object_layout.mdFixing Lib/turtledemo/turtle.cfgFixing Lib/test/xmltestdata/c14n-20/out_inNsContent_c14nPrefixQnameXpathElem.xmlFixing Modules/_testcapi_feature_macros.incFixing Lib/test/cjkencodings/iso2022_jp-utf8.txtFixing Doc/library/pipes.rstFixing Lib/test/decimaltestdata/ln.decTestFixing Tools/msi/bundle/packagegroups/test.wxsFixing Python/intrinsics.cFixing Tools/msi/bundle/Default.thmFixing Mac/PythonLauncher/English.lproj/PreferenceWindow.nib/classes.nibFixing Modules/_blake2/impl/blake2s-load-xop.hFixing Include/warnings.hFixing PC/crtlicense.txtFixing pyconfig.h.inFixing Doc/library/mailbox.rstFixing PCbuild/unicodedata.vcxproj.filtersFixing Doc/library/_thread.rstFixing PC/pyshellext.rcFixing Doc/library/imaplib.rstFixing Doc/howto/instrumentation.rstFixing Lib/test/cjkencodings/cp949-utf8.txtFixing Doc/library/email.header.rstFixing Lib/test/decimaltestdata/dqRemainder.decTestFixing Modules/_xxtestfuzz/dictionaries/fuzz_json_loads.dictFixing Tools/msi/bundle/releaseweb.wixprojFixing Tools/msi/bundle/Default.ARM64.xslFixing Lib/test/test_tomllib/data/invalid/inline-table/define-twice.tomlFixing Tools/freeze/win32.htmlFixing Doc/library/winsound.rstFixing Modules/getpath.cFixing Lib/test/xmltestdata/c14n-20/out_inC14N1_c14nDefault.xmlFixing PC/frozen_dllmain.cFixing Modules/_blake2/impl/blake2-impl.hFixing Include/iterobject.hFixing aclocal.m4Fixing Modules/_ssl_data_300.hFixing Modules/_blake2/impl/blake2b-load-sse41.hFixing Modules/_xxtestfuzz/fuzz_json_loads_corpus/pass1.jsonFixing PCbuild/_overlapped.vcxproj.filtersFixing Objects/unicodectype.cFixing Lib/test/decimaltestdata/randoms.decTestFixing Lib/test/decimaltestdata/dqEncode.decTestFixing Lib/test/xmltestdata/c14n-20/out_inC14N3_c14nDefault.xmlFixing PCbuild/_wmi.vcxproj.filtersFixing Lib/idlelib/CREDITS.txtFixing Lib/test/xmltestdata/c14n-20/out_inNsXml_c14nDefault.xmlFixing Lib/test/xmltestdata/c14n-20/out_inC14N4_c14nTrim.xmlFixing Tools/msi/bundle/packagegroups/lib.wxsFixing Modules/_decimal/libmpdec/examples/README.txtFixing Tools/msi/core/core.wixprojFixing Lib/test/xmltestdata/c14n-20/out_inNsDefault_c14nPrefix.xmlFixing Lib/test/test_email/data/msg_06.txtFixing PCbuild/_multiprocessing.vcxproj.filtersFixing PCbuild/pylauncher.vcxproj.filtersFixing Lib/test/test_tomllib/data/invalid/literal-str/unclosed.tomlFixing Lib/test/decimaltestdata/maxmag.decTestFixing Lib/test/xmltestdata/c14n-20/c14nQname.xmlFixing Lib/test/test_email/data/msg_44.txtFixing Tools/cases_generator/interpreter_definition.mdFixing Lib/test/levenshtein_examples.jsonFixing Lib/test/xmltestdata/c14n-20/out_inNsSuperfluous_c14nDefault.xmlFixing Include/internal/pycore_ast_state.hFixing Modules/_decimal/libmpdec/literature/matrix-transform.txtFixing Doc/whatsnew/2.4.rstFixing Lib/test/test_tomllib/data/invalid/array/unclosed-empty.tomlFixing PCbuild/_testcapi.vcxprojFixing Modules/_xxtestfuzz/fuzz_json_loads_corpus/pass2.jsonFixing Lib/test/decimaltestdata/samequantum.decTestFixing Modules/_decimal/libmpdec/examples/divmod.cFixing Tools/msi/tcltk/tcltk.wixprojFixing Lib/test/cjkencodings/big5.txtFixing Lib/test/xmltestdata/c14n-20/doc.dtdFixing PC/icons/logo.svgFixing Modules/cjkcodecs/mappings_hk.hFixing Lib/test/test_tomllib/data/invalid/array/unclosed-after-item.tomlFixing PC/icons/py.svgFixing Doc/library/xml.sax.utils.rstFixing Lib/test/cjkencodings/iso2022_jp.txtFixing PCbuild/liblzma.vcxproj.filtersFixing Modules/_xxtestfuzz/fuzz_csv_reader_corpus/test.csvFixing Doc/library/pyexpat.rstFixing Modules/_hacl/Hacl_Streaming_SHA2.cFixing Doc/library/sunau.rstFixing Lib/test/test_tomllib/data/invalid/array/file-end-after-val.tomlFixing Lib/test/decimaltestdata/dqCanonical.decTestFixing Lib/test/xmltestdata/c14n-20/c14nTrim.xmlFixing PCbuild/_uuid.vcxproj.filtersFixing Modules/_decimal/docstrings.hFixing Modules/_ssl_data_111.hFixing Objects/dictnotes.txtFixing Misc/valgrind-python.suppFixing Objects/capsule.cFixing Doc/faq/installed.rstFixing PCbuild/_overlapped.vcxprojFixing Lib/test/xmltestdata/c14n-20/out_inNsContent_c14nQnameXpathElem.xmlFixing Lib/test/decimaltestdata/ddNextPlus.decTestFixing Lib/test/xmltestdata/c14n-20/c14nPrefixQname.xmlFixing Modules/cjkcodecs/READMEFixing Tools/msi/ucrt/ucrt.wixprojFixing Lib/test/test_tomllib/data/valid/trailing-comma.tomlFixing Lib/test/decimaltestdata/ddSameQuantum.decTestFixing Doc/library/pathlib-inheritance.svgFixing PCbuild/_testimportmultiple.vcxproj.filtersFixing PCbuild/_testmultiphase.vcxprojFixing PCbuild/prepare_ssl.batFixing Lib/test/test_tomllib/data/invalid/table/eof-after-opening.tomlFixing Tools/msi/bundle/packagegroups/core.wxsFixing Lib/test/decimaltestdata/ddMaxMag.decTestFixing Tools/msi/dev/dev_d.wixprojFixing Lib/test/decimaltestdata/ddToIntegral.decTestFixing Doc/howto/ipaddress.rstFixing Doc/reference/introduction.rstFixing PCbuild/pythonw.vcxproj.filtersFixing Doc/tutorial/appetite.rstFixing PCbuild/select.vcxproj.filtersFixing Modules/_blake2/impl/blake2s-round.hFixing Doc/library/modulefinder.rstFixing Doc/library/text.rstFixing Lib/test/decimaltestdata/dqDivide.decTestFixing Doc/library/email.charset.rstFixing PCbuild/_uuid.vcxprojFixing Doc/library/grp.rstFixing Modules/_decimal/libmpdec/literature/umodarith.lispFixing Doc/whatsnew/2.1.rstFixing Mac/PythonLauncher/English.lproj/MyDocument.nib/classes.nibFixing Tools/msi/bundle/packagegroups/crt.wxsFixing Modules/_decimal/libmpdec/literature/mulmod-ppro.txtFixing Tools/msi/exe/exe.wixprojFixing Mac/Icons/ReadMe.txtFixing PCbuild/_testmultiphase.vcxproj.filtersFixing Lib/test/decimaltestdata/dqAbs.decTestFixing PCbuild/_decimal.vcxproj.filtersFixing Tools/msi/test/test.wixprojFixing Lib/test/decimaltestdata/dqBase.decTestFixing Lib/test/decimaltestdata/dqNextPlus.decTestFixing Doc/c-api/marshal.rstFixing PCbuild/_bz2.vcxprojFixing PC/icons/pythonw.svgFixing Lib/test/xmltestdata/c14n-20/out_inNsXml_c14nPrefix.xmlFixing Lib/test/test_tomllib/data/valid/empty-inline-table.jsonFixing Modules/_sha3/LICENSEFixing Lib/test/ieee754.txtFixing Tools/msi/wix.propsFixing Doc/library/telnetlib.rstFixing PCbuild/select.vcxprojFixing Doc/whatsnew/2.0.rstFixing Doc/library/binary.rstFixing Python/getopt.cFixing PCbuild/tix.vcxprojFixing Lib/test/decimaltestdata/ddLogB.decTestFixing Lib/test/cjkencodings/gb2312-utf8.txtFixing PCbuild/_sqlite3.vcxprojFixing Lib/test/decimaltestdata/ddFMA.decTestFixing Modules/cjkcodecs/emu_jisx0213_2000.hFixing Tools/msi/sign_build.ps1Fixing Lib/test/decimaltestdata/ddClass.decTestFixing Lib/test/test_tomllib/data/valid/dates-and-times/localtime.tomlFixing Lib/test/decimaltestdata/abs.decTestFixing Lib/test/decimaltestdata/ddMax.decTestFixing Lib/test/decimaltestdata/dqLogB.decTestFixing Mac/BuildScript/README.rstFixing Lib/test/test_tomllib/data/invalid/array-of-tables/overwrite-bool-with-aot.tomlFixing Doc/library/wave.rstFixing Lib/test/xmltestdata/c14n-20/out_inC14N1_c14nComment.xmlFixing Doc/library/gzip.rstFixing Doc/using/mac.rstFixing Lib/test/decimaltestdata/log10.decTestFixing Doc/library/nis.rstFixing PCbuild/_testconsole.vcxproj.filtersFixing Tools/msi/exe/exe_pdb.wixprojFixing Lib/test/test_tomllib/data/valid/no-newlines.tomlFixing Lib/test/xmltestdata/c14n-20/out_inNsRedecl_c14nDefault.xmlFixing Lib/test/test_email/data/msg_16.txtFixing Lib/test/test_tomllib/data/invalid/boolean/invalid-false-casing.tomlFixing PC/classicAppCompat.can.xmlFixing Modules/_decimal/tests/runall-memorydebugger.shFixing PCbuild/venvwlauncher.vcxproj.filtersFixing Doc/library/trace.rstFixing Doc/library/getopt.rstFixing Doc/whatsnew/3.5.rstFixing Doc/library/sndhdr.rstFixing Modules/cjkcodecs/mappings_jp.hFixing PC/icons/setup.svgFixing Lib/test/empty.vbsFixing .github/problem-matchers/gcc.jsonFixing Doc/library/wsgiref.rstFixing PCbuild/winsound.vcxproj.filtersFixing Lib/test/xmltestdata/c14n-20/out_inNsRedecl_c14nPrefix.xmlFixing Modules/_blake2/impl/blake2-config.hFixing Lib/test/test_tomllib/data/invalid/inline-table/unclosed-empty.tomlFixing Lib/test/decimaltestdata/multiply.decTestFixing PCbuild/python3dll.vcxprojFixing Lib/test/cjkencodings/gbk-utf8.txtFixing Lib/test/test_tomllib/data/invalid/non-scalar-escaped.tomlFixing Python/Python-ast.cFixing Modules/_decimal/libmpdec/literature/six-step.txtFixing Doc/howto/index.rstFixing Lib/test/cjkencodings/johab.txtFixing PCbuild/winsound.vcxprojFixing Lib/idlelib/ChangeLogFixing Lib/ctypes/macholib/README.ctypesFixing PCbuild/pywlauncher.vcxprojFixing Doc/c-api/gcsupport.rstFixing PCbuild/_lzma.vcxproj.filtersFixing Lib/test/decimaltestdata/ddAbs.decTestFixing Lib/test/test_tomllib/data/invalid/unclosed-string.tomlFixing Lib/test/test_email/data/msg_04.txtFixing Doc/library/winreg.rstFixing Doc/library/pwd.rstFixing Lib/test/decimaltestdata/dqNextMinus.decTestFixing Lib/test/decimaltestdata/ddCopySign.decTestFixing Lib/test/test_email/data/msg_19.txtFixing PCbuild/_testembed.vcxprojFixing Lib/test/test_email/data/msg_43.txtFixing Modules/_decimal/libmpdec/README.txtFixing Tools/msi/bundle/bootstrap/pch.hFixing Doc/library/spwd.rstFixing Doc/library/site.rstFixing Modules/_decimal/libmpdec/examples/multiply.cFixing Lib/test/test_email/data/msg_05.txtFixing PCbuild/_msi.vcxproj.filtersFixing Lib/test/mailcap.txtFixing Doc/library/cgitb.rstFixing Mac/BuildScript/resources/Welcome.rtfFixing Mac/Resources/app/PkgInfoFixing PCbuild/_socket.vcxprojFixing Misc/NEWS.d/next/Core and Builtins/2022-10-06-23-32-11.gh-issue-98003.xWE0Yu.rstFixing PCbuild/_ssl.vcxproj.filtersFixing Doc/library/dbm.rstFixing Tools/msi/bundle/packagegroups/pip.wxsFixing Tools/msi/bundle/snapshot.wixprojFixing Modules/cjkcodecs/mappings_kr.hFixing Tools/msi/test/test_d.wixprojFixing Doc/library/curses.ascii.rstFixing Lib/test/decimaltestdata/exp.decTestFixing Doc/library/xml.sax.rstFixing PCbuild/python_uwp.vcxproj.filtersFixing Lib/test/decimaltestdata/nexttoward.decTestFixing PCbuild/_wmi.vcxprojFixing PCbuild/_hashlib.vcxproj.filterstrim trailing whitespace.................................................Passed |
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood approved these changesMay 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Best to leaveend-of-file-fixer for a followup PR, if it affects so many files.
This looks great!
Member
AlexWaygood commentedMay 8, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Azure Pipelines also isn't a required check, and it often fails due to flaky Windows tests that sometimes cause pre-commit-hooks is also a better-tested project than (We could even consider enabling pre-commit.ci, which would mean fixes would be automatically pushed to PR branches.) |
It does. This checks it on GitHub Actions which makes it easier to set as a required check, which should avoid accidental whitespace additions like in#103974
I check one, and yes, |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
erlend-aasland approved these changesMay 8, 2023
Uh oh!
There was an error while loading.Please reload this page.
AlexWaygood approved these changesMay 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems unlikely that this patch is the cause of the segfault on MacOS
Yup, I re-ran macOS and it now passes ✅ |
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull requestMay 8, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
carljm added a commit to carljm/cpython that referenced this pull requestMay 9, 2023
* main: (47 commits)pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)pythonGH-104284: Fix documentation gettext build (python#104296)pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)pythongh-99108: fix typo in Modules/Setup (python#104293)pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172)pythongh-103193: Improve `getattr_static` test coverage (python#104286) Trim trailing whitespace and test on CI (python#104275)pythongh-102500: Remove mention of bytes shorthand (python#104281)pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256)pythongh-99108: Replace SHA3 implementation HACL* version (python#103597)pythongh-104273: Remove redundant len() calls in argparse function (python#104274)pythongh-64660: Don't hardcode Argument Clinic return converter result variable name (python#104200)pythongh-104265 Disallow instantiation of `_csv.Reader` and `_csv.Writer` (python#104266)pythonGH-102613: Improve performance of `pathlib.Path.rglob()` (pythonGH-104244)pythongh-103650: Fix perf maps address format (python#103651)pythonGH-89812: Churn `pathlib.Path` methods (pythonGH-104243) ...
carljm added a commit to carljm/cpython that referenced this pull requestMay 9, 2023
* main: (29 commits)pythongh-104276: Make `_struct.unpack_iterator` type use type flag instead of custom constructor (python#104277)pythongh-97696: Move around and update the whatsnew entry for asyncio eager task factory (python#104298)pythongh-103193: Fix refleaks in `test_inspect` and `test_typing` (python#104320) require-pr-label.yml: Add missing "permissions:" (python#104309)pythongh-90656: Add platform triplets for 64-bit LoongArch (LA64) (python#30939)pythongh-104180: Read SOCKS proxies from macOS System Configuration (python#104181)pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)pythonGH-104284: Fix documentation gettext build (python#104296)pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)pythongh-99108: fix typo in Modules/Setup (python#104293)pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172)pythongh-103193: Improve `getattr_static` test coverage (python#104286) Trim trailing whitespace and test on CI (python#104275)pythongh-102500: Remove mention of bytes shorthand (python#104281)pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256)pythongh-99108: Replace SHA3 implementation HACL* version (python#103597) ...
bedevere-bot commentedAug 21, 2023
GH-108215 is a backport of this pull request to the3.11 branch. |
hugovk added a commit that referenced this pull requestAug 22, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixespython/core-workflow#429.
Follow on from#102531.