Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-104273: Remove redundant len() calls in argparse function#104274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
terryjreedy merged 1 commit intopython:mainfromburaksaler:fix-issues-104273
May 7, 2023

Conversation

buraksaler
Copy link
Contributor

@buraksalerburaksaler commentedMay 7, 2023
edited by bedevere-bot
Loading

@bedevere-bot

This comment was marked as resolved.

@ghost
Copy link

ghost commentedMay 7, 2023
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@terryjreedyterryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Calculating an expression once instead of thrice or more is a common optimization.

@terryjreedy
Copy link
Member

Burak, I am merging this because to me it makes the code a bit clearer. Redundant expressions can raise the question of whether, in this case, indent was changed so that its len could change. I otherwise would agree with 2 other core developers that this does not do enough to be worth merging. So next time, please about a meatier improvement. Or find an actual bug issue.

buraksaler reacted with thumbs up emoji

@terryjreedyterryjreedy changed the titlegh-104273: Reduce number of calls to len()gh-104273: Remove redundant len() calls in argparse functionMay 7, 2023
@terryjreedyterryjreedy merged commit01cc9c1 intopython:mainMay 7, 2023
@buraksaler
Copy link
ContributorAuthor

@terryjreedy thank you for the feedback. I'll try my best

bumper-furkan-onder and doganmurat reacted with thumbs up emoji

carljm added a commit to carljm/cpython that referenced this pull requestMay 9, 2023
* main: (47 commits)pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)pythonGH-104284: Fix documentation gettext build (python#104296)pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)pythongh-99108: fix typo in Modules/Setup (python#104293)pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172)pythongh-103193: Improve `getattr_static` test coverage (python#104286)  Trim trailing whitespace and test on CI (python#104275)pythongh-102500: Remove mention of bytes shorthand (python#104281)pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256)pythongh-99108: Replace SHA3 implementation HACL* version (python#103597)pythongh-104273: Remove redundant len() calls in argparse function (python#104274)pythongh-64660: Don't hardcode Argument Clinic return converter result variable name (python#104200)pythongh-104265 Disallow instantiation of `_csv.Reader` and `_csv.Writer` (python#104266)pythonGH-102613: Improve performance of `pathlib.Path.rglob()` (pythonGH-104244)pythongh-103650: Fix perf maps address format (python#103651)pythonGH-89812: Churn `pathlib.Path` methods (pythonGH-104243)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@terryjreedyterryjreedyterryjreedy approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@buraksaler@bedevere-bot@terryjreedy

[8]ページ先頭

©2009-2025 Movatter.jp