Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-104265 Disallow instantiation of_csv.Reader and_csv.Writer#104266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
erlend-aasland merged 13 commits intopython:mainfromchgnrdv:_csv-make-Reader-Writer-types-non-instantiableMay 7, 2023
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
13 commits Select commitHold shift + click to select a range
ae69f9b Disallow instantiation and subtyping of `_csv.Reader` and `_csv.Write…
chgnrdv7d1fcd8 added test
chgnrdvaa34fae changed tests to use check_disallow_instantiation, separated tests
chgnrdv6c45ff8 reverted Py_TPFLAGS_BASETYPE flag deletion, removed corresponding tests
chgnrdv7d9ec2a 📜🤖 Added by blurb_it.
blurb-it[bot]19bddd0 Update 2023-05-07-16-13-07.gh-issue-104265.fU60bZ.rst
chgnrdvb3f4a65 Update 2023-05-07-16-13-07.gh-issue-104265.fU60bZ.rst
chgnrdva022e91 Update 2023-05-07-16-13-07.gh-issue-104265.fU60bZ.rst
chgnrdv52aacfd 📜🤖 Added by blurb_it.
blurb-it[bot]d31d214 Delete 2023-05-07-16-13-07.gh-issue-104265.fU60bZ.rst
chgnrdv2804744 Update Misc/NEWS.d/next/Library/2023-05-07-19-56-45.gh-issue-104265.f…
erlend-aasland8255467 applied suggestion by erlend-aasland
chgnrdv73609a8 Merge branch '_csv-make-Reader-Writer-types-non-instantiable' of gith…
chgnrdvFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Update 2023-05-07-16-13-07.gh-issue-104265.fU60bZ.rst
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commita022e91600542a25e011649873a2c7af7adb080f
There are no files selected for viewing
2 changes: 1 addition & 1 deletionMisc/NEWS.d/next/Library/2023-05-07-16-13-07.gh-issue-104265.fU60bZ.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| Fix a :mod:`!_csv` module regression where :class:`!_csv.Reader` and :class:`!_csv.Writer` types became directly instantiable which led to their improper initialization and subsequent crashes. The regression was introduced in 3.10.0a4 with PR 23224 (:issue:`14935`). |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.