NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-96471: Add threading queue shutdown#104225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

EpicWink wants to merge3 commits intopython:mainfromEpicWink:threading-queue-shutdown

Closed

gh-96471: Add threading queue shutdown#104225

EpicWink wants to merge3 commits intopython:mainfromEpicWink:threading-queue-shutdown

Conversation

Copy link

Contributor

EpicWink commentedMay 6, 2023•
edited by github-actionsbot
Loading

Threading-only changes from#102499 (on top of#96474)

Issue:Queue shutdown #96471

📚 Documentation preview 📚:https://cpython-previews--104225.org.readthedocs.build/

EpicWink requested a review fromrhettinger as acode owner

May 6, 2023 04:25

bedevere-bot mentioned this pull request

May 6, 2023

Queue shutdown#96471

Open

bedevere-bot added the awaiting review label

May 6, 2023

Copy link

ContributorAuthor

EpicWink commentedMay 6, 2023

@willingc ready for review

EpicWink force-pushed thethreading-queue-shutdown branch fromfa1debe toddeb9b6Compare

May 6, 2023 04:27

EpicWinkand others added2 commits

May 6, 2023 14:34

Add threading queue shutdown

cd8ceaf

* Include docs

Fix queue shutdown

9c2971b

* Include raised exception in docstrings* Handle queue shutdown in task_done and join* Factor out queue-state checks and updates to methods* Logic fixes in qsize, get and shutdown* Don't set unfinished_tasks to 0 on immediate shutdown* Updated tests* Document feature added in 3.13

EpicWink force-pushed thethreading-queue-shutdown branch fromddeb9b6 to9c2971bCompare

May 6, 2023 04:38