Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99113: Add a check for Py_MOD_PER_INTERPRETER_GIL_SUPPORTED#104206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commentedMay 5, 2023•
edited
Loading

Py_MOD_PER_INTERPRETER_GIL_SUPPORTED is a new supported value forPy_mod_multiple_interpreters, added ingh-104205.

(This is blocked untilPyInterpreterState.ceval.own_gil is added ingh-104204.)

ericsnowcurrently added a commit that referenced this pull requestMay 5, 2023
Here we are doing no more than adding the value for Py_mod_multiple_interpreters and using it for stdlib modules.  We will start checking for it ingh-104206 (once PyInterpreterState.ceval.own_gil is added ingh-104204).
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

BTW, the branch in lines 295-300 seems lack coverage (disclaimer: I only rantest_import)

ericsnowcurrently reacted with thumbs up emoji
@ericsnowcurrently
Copy link
MemberAuthor

Thanks for pointing out about the missing test coverage. I've added it. I also did likewise for the similar case wherePy_mod_create is provided multiple times, which did not have test coverage either.

erlend-aasland reacted with rocket emoji

@erlend-aasland
Copy link
Contributor

Thanks for pointing out about the missing test coverage. I've added it. I also did likewise for the similar case wherePy_mod_create is provided multiple times, which did not have test coverage either.

Nice, thanks! I can confirm that those branches are now covered.

ericsnowcurrently reacted with hooray emoji

@ericsnowcurrentlyericsnowcurrentlyenabled auto-merge (squash)May 6, 2023 21:52
@ericsnowcurrentlyericsnowcurrently merged commitfff193b intopython:mainMay 6, 2023
@ericsnowcurrentlyericsnowcurrently deleted the own-gil-extension-check branchMay 6, 2023 21:57
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull requestMay 8, 2023
…4205)Here we are doing no more than adding the value for Py_mod_multiple_interpreters and using it for stdlib modules.  We will start checking for it inpythongh-104206 (once PyInterpreterState.ceval.own_gil is added inpythongh-104204).
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull requestMay 8, 2023
…ythongh-104206)Py_MOD_PER_INTERPRETER_GIL_SUPPORTED is a new supported value for Py_mod_multiple_interpreters, added inpythongh-104205.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@encukouencukouAwaiting requested review from encukou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericsnowcurrently@erlend-aasland@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp