Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-103247: bypass the import cache on the _require_loader helper#104186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
FFY00 merged 2 commits intopython:mainfromFFY00:gh-103247-_require_loader
Aug 24, 2023

Conversation

FFY00
Copy link
Member

@FFY00FFY00 commentedMay 5, 2023•
edited by bedevere-bot
Loading

This is not a fix for the importlib test monkeypatching leakage but it's something that we probably should be doing anyway.

This is not a fix for the importlib test monkeypatching leakage but it'ssomething that we probably should be doing anyway.Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Copy link
MemberAuthor

cc@JelleZijlstra as the original reporter

@FFY00
Copy link
MemberAuthor

It seems this fell off mental work pool and I only noticed it now. Since we have approvals, I am gonna update the branch and schedule it for merging.

@FFY00FFY00enabled auto-merge (squash)August 24, 2023 20:25
@FFY00FFY00 merged commitfeb9a49 intopython:mainAug 24, 2023
@carljmcarljm mentioned this pull requestAug 30, 2023
2 tasks
@carljm
Copy link
Member

Bisection shows that the merge of this PR introduced a reference leak intest_import, so all refleak buildbots are red:#108696

@FFY00
Copy link
MemberAuthor

@carljm thanks for the catch, let's revert then.

@carljm
Copy link
Member

@carljm thanks for the catch, let's revert then.

#108698

sunmy2019 reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@brettcannonbrettcannonbrettcannon approved these changes

@sunmy2019sunmy2019sunmy2019 approved these changes

@encukouencukouAwaiting requested review from encukou

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@FFY00@carljm@brettcannon@sunmy2019@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp