Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-64658: Expand Argument Clinic return converter docs#104175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedMay 4, 2023•
edited by github-actionsbot
Loading

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I only understand AC in the vaguest terms, but that is definitely a sentence that makes grammatical sense! :)

erlend-aasland reacted with laugh emoji
@erlend-aasland

This comment was marked as outdated.

@erlend-aaslanderlend-aasland changed the titlegh-64658: Amend Argument Clinic return converter docsgh-64658: Expand Argument Clinic return converter docsMay 4, 2023
@erlend-aasland
Copy link
ContributorAuthor

BTW, I removed the reference to theinit converter; it's only used internally by AC anyways.

@erlend-aasland
Copy link
ContributorAuthor

FTR, I'm landing this soon. We can easily fix nitpicks in the docs later (no issue needed).

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks fine to me, but I still feel like a very underqualified reviewer here :)

erlend-aasland reacted with heart emoji
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aaslanderlend-aasland merged commit721a783 intopython:mainMay 5, 2023
@erlend-aaslanderlend-aasland deleted the clinic-doc-ret-conv branchMay 5, 2023 11:32
@erlend-aaslanderlend-aasland removed the needs backport to 3.11only security fixes labelMay 5, 2023
@bedevere-bot
Copy link

GH-104198 is a backport of this pull request to the3.11 branch.

carljm added a commit to carljm/cpython that referenced this pull requestMay 5, 2023
* main: (61 commits)pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)pythongh-64658: Expand Argument Clinic return converter docs (python#104175)pythonGH-103092: port `_asyncio` freelist to module state (python#104196)pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)pythongh-104190: fix ubsan crash (python#104191)pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)pythongh-68968: Correcting message display issue with assertEqual (python#103937)pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)pythongh-91896: Deprecate collections.abc.ByteString (python#102096)pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)pythongh-102500: Document PEP 688 (python#102571)pythongh-102500: Implement PEP 688 (python#102521)pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood left review comments

Assignees
No one assigned
Labels
awaiting core reviewdocsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[doc] No Argument Clinic documentation on how to specify a return converter
3 participants
@erlend-aasland@bedevere-bot@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp