NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-64631: Test exception messages in cloned Argument Clinic funcs#104167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

erlend-aasland merged 2 commits intopython:mainfromerlend-aasland:clinic-clone

May 5, 2023

Merged

gh-64631: Test exception messages in cloned Argument Clinic funcs#104167

erlend-aasland merged 2 commits intopython:mainfromerlend-aasland:clinic-clone

May 5, 2023

Conversation

Copy link

Contributor

erlend-aasland commentedMay 4, 2023•
edited by bedevere-bot
Loading

Issue:Argument Clinic: when cloning functions with path_t, path_t retains the old name #64631

pythongh-64631: Test exception messages in cloned Argument Clinic funcs

4a4e328

bedevere-bot mentioned this pull request

May 4, 2023

Argument Clinic: when cloning functions with path_t, path_t retains the old name#64631

Closed

bedevere-bot added the awaiting core review label

May 4, 2023

Add test with custom converter a la poxismodule path_t

39de88f

erlend-aasland added the skip news label

May 4, 2023

erlend-aasland requested review fromserhiy-storchaka andlarryhastings

May 4, 2023 14:11

Copy link

ContributorAuthor

erlend-aasland commentedMay 5, 2023

I consider this a non-controversial change (increasing test coverage is always a good thing). I'm landing this later today.

erlend-aasland linked an issue

May 5, 2023

that may beclosed by this pull request

Argument Clinic: when cloning functions with path_t, path_t retains the old name#64631

Closed

erlend-aasland merged commitd0b4abe intopython:main

May 5, 2023

bedevere-bot removed the awaiting core review label

May 5, 2023

erlend-aasland deleted the clinic-clone branch

May 5, 2023 12:08

carljm added a commit to carljm/cpython that referenced this pull request

May 5, 2023

Merge branch 'main' into inlinecomp2

8a78a36

* main: (61 commits)pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)pythongh-64658: Expand Argument Clinic return converter docs (python#104175)pythonGH-103092: port `_asyncio` freelist to module state (python#104196)pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)pythongh-104190: fix ubsan crash (python#104191)pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)pythongh-68968: Correcting message display issue with assertEqual (python#103937)pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)pythongh-91896: Deprecate collections.abc.ByteString (python#102096)pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)pythongh-102500: Document PEP 688 (python#102571)pythongh-102500: Implement PEP 688 (python#102521)pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)  ...