Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-104106: Add gcc fallback of mkfifoat/mknodat for macOS#104129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
biergaizi commentedMay 3, 2023
This patch contains a typo. |
Fix done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Currently, dev-lang/python-3.11.3 is unbuildable on macOS due to GCCincompatibility. There exists two "#ifdef" checks for the system callsmkfifoat() and mknodat(), which are not compatible with GCC. Becausethey're defined using the __builtin_available() function - specific toclang without a fallback for GCC, they're never defined, thus creatingthe following errors: ./Modules/posixmodule.c:15647:23: error: 'HAVE_MKFIFOAT_RUNTIME' undeclared (first use in this function); did you mean 'HAVE_MKDIRAT_RUNTIME'? ./Modules/posixmodule.c:15651:22: error: 'HAVE_MKNODAT_RUNTIME' undeclared (first use in this function); did you mean 'HAVE_MKDIRAT_RUNTIME'?This bug [1] has already been reported to upstream with a patch [2]waiting to be merged. This commit applies the upstream patch to addthe missing GCC fallbacks.[1]python/cpython#104106[2]python/cpython#104129Closes:https://bugs.gentoo.org/905618Signed-off-by: Yifeng Li <tomli@tomli.me>
Thanks@corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry,@corona10, I could not cleanly backport this to |
pythongh-104129).(cherry picked from commite5b8b19)Co-authored-by: Dong-hee Na <donghee.na@python.org>
bedevere-bot commentedMay 5, 2023
GH-104187 is a backport of this pull request to the3.11 branch. |
* main: (61 commits)pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)pythongh-64658: Expand Argument Clinic return converter docs (python#104175)pythonGH-103092: port `_asyncio` freelist to module state (python#104196)pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)pythongh-104190: fix ubsan crash (python#104191)pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)pythongh-68968: Correcting message display issue with assertEqual (python#103937)pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)pythongh-91896: Deprecate collections.abc.ByteString (python#102096)pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)pythongh-102500: Document PEP 688 (python#102571)pythongh-102500: Implement PEP 688 (python#102521)pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536) ...
Uh oh!
There was an error while loading.Please reload this page.