Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.10] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (GH-102953)#104128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 7 commits intopython:3.10fromopenSUSE-Python:PEP706-for-py310
May 10, 2023

Conversation

mcepl
Copy link
Contributor

@mceplmcepl commentedMay 3, 2023
edited by bedevere-bot
Loading

@encukou
Copy link
Member

Thanks for getting to this sooner than I did!
But seehttps://github.com/python/cpython/pull/103832/commits for the changes needed in the backport.

@mcepl
Copy link
ContributorAuthor

I was basing it on this 3.11 PR, I know better than using master branch for this. But yes, I will re-check, that everything in that PR has been included.

@encukou
Copy link
Member

Ah, sorry! I just looked at theversionchanged:: 3.12 and gave a quick comment. Will do a proper review later.

@mcepl
Copy link
ContributorAuthor

Yes, you were right, I missed those, not sure how I have managed to do that.

@mcepl
Copy link
ContributorAuthor

I don't understand those Windows failures … shouldn’t it be covered byae62b3a ?

@encukou
Copy link
Member

encukou commentedMay 4, 2023
edited
Loading

No.ae62b3a is for Solaris or BSD, supported platforms (per PEP 11) don't need it.

This change made me get a Windows VM, so I'll investigate there. Can't promise it'll be this week though.

@encukou
Copy link
Member

It's related to a change made while backporting, going from

ifmodeisnotNoneandos_helper.can_chmod():

to just

ifmodeisnotNone:

Thecan_chmod() determines whether chmod can set all the mode bits. According tothe docs, it's only limited on Windows, so I'll hardcode that. (It's also limited on WASI, but in 3.10 tests we don't care.)

I can't push fixes to your repo so I opened#104327.

@mcepl
Copy link
ContributorAuthor

I can't push fixes to your repo so I opened#104327.

Sorry about that, I don’t know how to set it up with the existing PR.

@encukouencukou added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 9, 2023
@mcepl
Copy link
ContributorAuthor

Couldn’t you just make PR tohttps://github.com/openSUSE-Python/cpython/tree/PEP706-for-py310 ?

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@encukou for commit7ab6233 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 9, 2023
@encukou
Copy link
Member

I don't think I could run CPython buildbots on another repo.
But since you've updated this PR quickly, I'll run them here.

@encukou
Copy link
Member

The red checks are unrelated: Python 3.10 doesn't build on Wasm, and RtD's OpenSSL is too old for urllib3.

@encukouencukou merged commit425065b intopython:3.10May 10, 2023
@encukou
Copy link
Member

Thanks for the backport!

@mceplmcepl deleted the PEP706-for-py310 branchMay 10, 2023 12:27
@mcepl
Copy link
ContributorAuthor

So, now 3.9! :)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@encukouencukouencukou left review comments

@ethanfurmanethanfurmanAwaiting requested review from ethanfurmanethanfurman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mcepl@encukou@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp