Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
[3.10] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (GH-102953)#104128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for getting to this sooner than I did! |
I was basing it on this 3.11 PR, I know better than using master branch for this. But yes, I will re-check, that everything in that PR has been included. |
Ah, sorry! I just looked at the |
…et the sticky bit (pythonGH-103831)Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end isenough.Backport ofc8c3956
Yes, you were right, I missed those, not sure how I have managed to do that. |
I don't understand those Windows failures … shouldn’t it be covered byae62b3a ? |
Uh oh!
There was an error while loading.Please reload this page.
encukou commentedMay 4, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
No.ae62b3a is for Solaris or BSD, supported platforms (per PEP 11) don't need it. This change made me get a Windows VM, so I'll investigate there. Can't promise it'll be this week though. |
It's related to a change made while backporting, going from ifmodeisnotNoneandos_helper.can_chmod(): to just ifmodeisnotNone: The I can't push fixes to your repo so I opened#104327. |
Sorry about that, I don’t know how to set it up with the existing PR. |
Couldn’t you just make PR tohttps://github.com/openSUSE-Python/cpython/tree/PEP706-for-py310 ? |
bedevere-bot commentedMay 9, 2023
I don't think I could run CPython buildbots on another repo. |
The red checks are unrelated: Python 3.10 doesn't build on Wasm, and RtD's OpenSSL is too old for urllib3. |
Thanks for the backport! |
So, now 3.9! :) |
Uh oh!
There was an error while loading.Please reload this page.
Manual port ofgh-102953 to 3.10.
Please, review.