Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
Improve assert_type phrasing#104081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Improve assert_type phrasing#104081
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I'd like to make the fact that this does nothing at runtimereally obvious, since I suspect this is unintuitive for users who areunfamiliar with static type checking.I thought of this because ofhttps://discuss.python.org/t/add-arg-check-type-to-types/26384wherein I'm skeptical that the user really did want `assert_type`.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good minus the typo
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
I always thought it shouldn't have been called |
Thanks@hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry@hauntsaninja, I had trouble checking out the |
Thanks@hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
bedevere-bot commentedMay 2, 2023
GH-104084 is a backport of this pull request to the3.11 branch. |
I'd like to make the fact that this does nothing at runtimereally obvious, since I suspect this is unintuitive for users who areunfamiliar with static type checking.I thought of this because ofhttps://discuss.python.org/t/add-arg-check-type-to-types/26384wherein I'm skeptical that the user really did want `assert_type`.(cherry picked from commit82ba6ce)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Improve assert_type phrasing (GH-104081)I'd like to make the fact that this does nothing at runtimereally obvious, since I suspect this is unintuitive for users who areunfamiliar with static type checking.I thought of this because ofhttps://discuss.python.org/t/add-arg-check-type-to-types/26384wherein I'm skeptical that the user really did want `assert_type`.(cherry picked from commit82ba6ce)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
* main:pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827)pythongh-65022: Fix description of tuple return value in copyreg (python#103892)pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526)pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962)pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744)pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999)pythonGH-103484: Fix redirected permanently URLs (python#104001) Improve assert_type phrasing (python#104081)pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998)pythonGH-103472: close response in HTTPConnection._tunnel (python#103473)pythongh-88496: IDLE - fix another test on macOS (python#104075)pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074)pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072)pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071)
* main: (760 commits)pythonGH-104102: Optimize `pathlib.Path.glob()` handling of `../` pattern segments (pythonGH-104103)pythonGH-104104: Optimize `pathlib.Path.glob()` by avoiding repeated calls to `os.path.normcase()` (pythonGH-104105)pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827)pythongh-65022: Fix description of tuple return value in copyreg (python#103892)pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526)pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962)pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744)pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999)pythonGH-103484: Fix redirected permanently URLs (python#104001) Improve assert_type phrasing (python#104081)pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998)pythonGH-103472: close response in HTTPConnection._tunnel (python#103473)pythongh-88496: IDLE - fix another test on macOS (python#104075)pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074)pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072)pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071)pythongh-104057: Fix direct invocation of test_super (python#104064)pythongh-87092: Expose assembler to unit tests (python#103988)pythongh-97696: asyncio eager tasks factory (python#102853)pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054) ...
Uh oh!
There was an error while loading.Please reload this page.
I'd like to make the fact that this does nothing at runtime really obvious, since I suspect this is unintuitive for users who are unfamiliar with static type checking.
I thought of this because of
https://discuss.python.org/t/add-arg-check-type-to-types/26384 wherein I'm a little skeptical that the user really did want
assert_type
.📚 Documentation preview 📚:https://cpython-previews--104081.org.readthedocs.build/