Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve assert_type phrasing#104081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hauntsaninja merged 2 commits intopython:mainfromhauntsaninja:assert-type
May 2, 2023
Merged

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninjahauntsaninja commentedMay 2, 2023
edited
Loading

I'd like to make the fact that this does nothing at runtime really obvious, since I suspect this is unintuitive for users who are unfamiliar with static type checking.

I thought of this because of
https://discuss.python.org/t/add-arg-check-type-to-types/26384 wherein I'm a little skeptical that the user really did wantassert_type.


📚 Documentation preview 📚:https://cpython-previews--104081.org.readthedocs.build/

I'd like to make the fact that this does nothing at runtimereally obvious, since I suspect this is unintuitive for users who areunfamiliar with static type checking.I thought of this because ofhttps://discuss.python.org/t/add-arg-check-type-to-types/26384wherein I'm skeptical that the user really did want `assert_type`.
Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good minus the typo

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@gvanrossum
Copy link
Member

I always thought it shouldn't have been calledassert-something, because of this misunderstanding, but I was overruled. :-(

hauntsaninja reacted with thumbs up emoji

@hauntsaninjahauntsaninja merged commit82ba6ce intopython:mainMay 2, 2023
@miss-islington
Copy link
Contributor

Thanks@hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@hauntsaninja, I had trouble checking out the3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker 82ba6ce303d04a7b21034e38d220e23ca9f1dc0a 3.11

@hauntsaninjahauntsaninja deleted the assert-type branchMay 2, 2023 06:05
@hauntsaninjahauntsaninja added needs backport to 3.11only security fixes and removed needs backport to 3.11only security fixes labelsMay 2, 2023
@miss-islington
Copy link
Contributor

Thanks@hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-104084 is a backport of this pull request to the3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 2, 2023
I'd like to make the fact that this does nothing at runtimereally obvious, since I suspect this is unintuitive for users who areunfamiliar with static type checking.I thought of this because ofhttps://discuss.python.org/t/add-arg-check-type-to-types/26384wherein I'm skeptical that the user really did want `assert_type`.(cherry picked from commit82ba6ce)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelMay 2, 2023
AlexWaygood pushed a commit that referenced this pull requestMay 2, 2023
Improve assert_type phrasing (GH-104081)I'd like to make the fact that this does nothing at runtimereally obvious, since I suspect this is unintuitive for users who areunfamiliar with static type checking.I thought of this because ofhttps://discuss.python.org/t/add-arg-check-type-to-types/26384wherein I'm skeptical that the user really did want `assert_type`.(cherry picked from commit82ba6ce)Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
carljm added a commit to carljm/cpython that referenced this pull requestMay 2, 2023
* main:pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827)pythongh-65022: Fix description of tuple return value in copyreg (python#103892)pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526)pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962)pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744)pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999)pythonGH-103484: Fix redirected permanently URLs (python#104001)  Improve assert_type phrasing (python#104081)pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998)pythonGH-103472: close response in HTTPConnection._tunnel (python#103473)pythongh-88496: IDLE - fix another test on macOS (python#104075)pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074)pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072)pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071)
carljm added a commit to carljm/cpython that referenced this pull requestMay 2, 2023
* main: (760 commits)pythonGH-104102: Optimize `pathlib.Path.glob()` handling of `../` pattern segments (pythonGH-104103)pythonGH-104104: Optimize `pathlib.Path.glob()` by avoiding repeated calls to `os.path.normcase()` (pythonGH-104105)pythongh-103822: [Calendar] change return value to enum for day and month APIs (pythonGH-103827)pythongh-65022: Fix description of tuple return value in copyreg (python#103892)pythonGH-103525: Improve exception message from `pathlib.PurePath()` (pythonGH-103526)pythongh-84436: Add integration C API tests for immortal objects (pythongh-103962)pythongh-103743: Add PyUnstable_Object_GC_NewWithExtraData (pythonGH-103744)pythongh-102997: Update Windows installer to SQLite 3.41.2. (python#102999)pythonGH-103484: Fix redirected permanently URLs (python#104001)  Improve assert_type phrasing (python#104081)pythongh-102997: Update macOS installer to SQLite 3.41.2. (pythonGH-102998)pythonGH-103472: close response in HTTPConnection._tunnel (python#103473)pythongh-88496: IDLE - fix another test on macOS (python#104075)pythongh-94673: Hide Objects in PyTypeObject Behind Accessors (pythongh-104074)pythongh-94673: Properly Initialize and Finalize Static Builtin Types for Each Interpreter (pythongh-104072)pythongh-104016: Skip test for deeply neste f-strings on wasi (python#104071)pythongh-104057: Fix direct invocation of test_super (python#104064)pythongh-87092: Expose assembler to unit tests (python#103988)pythongh-97696: asyncio eager tasks factory (python#102853)pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygoodAlexWaygood is a code owner

Assignees

@hauntsaninjahauntsaninja

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@hauntsaninja@gvanrossum@miss-islington@bedevere-bot@JelleZijlstra

[8]ページ先頭

©2009-2025 Movatter.jp