Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-104049: do not expose on-disk location used by SimpleHTTPServer#104067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
gpshead approved these changesMay 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this fixes the fundamental problem, the local path should never have been exposed. I'm not sure taking the arbitrary binary data from the http request and allowing that to be rendered in the html's codec makes sense (high mojibake potential), but that doesn't feel important here.
using an error handler other than surrogatepass that elides or escapes values might also make sense.
furkanonder approved these changesMay 2, 2023
Uh oh!
There was an error while loading.Please reload this page.
Thanks@ethanfurman for the PR, and@gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9, 3.10, 3.11. |
Sorry@ethanfurman and@gpshead, I had trouble checking out the |
bedevere-bot commentedMay 3, 2023
GH-104119 is a backport of this pull request to the3.10 branch. |
bedevere-bot commentedMay 3, 2023
GH-104120 is a backport of this pull request to the3.9 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 3, 2023
…tHandler (pythonGH-104067)Do not expose the local server's on-disk location from `SimpleHTTPRequestHandler` when generating a directory index. (unnecessary information disclosure)---------(cherry picked from commitc7c3a60)Co-authored-by: Ethan Furman <ethan@stoneleaf.us>Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
bedevere-bot commentedMay 3, 2023
GH-104121 is a backport of this pull request to the3.8 branch. |
bedevere-bot commentedMay 3, 2023
GH-104122 is a backport of this pull request to the3.7 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 3, 2023
…tHandler (pythonGH-104067)Do not expose the local server's on-disk location from `SimpleHTTPRequestHandler` when generating a directory index. (unnecessary information disclosure)---------(cherry picked from commitc7c3a60)Co-authored-by: Ethan Furman <ethan@stoneleaf.us>Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 3, 2023
…tHandler (pythonGH-104067)Do not expose the local server's on-disk location from `SimpleHTTPRequestHandler` when generating a directory index. (unnecessary information disclosure)---------(cherry picked from commitc7c3a60)Co-authored-by: Ethan Furman <ethan@stoneleaf.us>Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Thanks@ethanfurman for the PR, and@gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
bedevere-bot commentedMay 3, 2023
GH-104123 is a backport of this pull request to the3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 3, 2023
…tHandler (pythonGH-104067)Do not expose the local server's on-disk location from `SimpleHTTPRequestHandler` when generating a directory index. (unnecessary information disclosure)---------(cherry picked from commitc7c3a60)Co-authored-by: Ethan Furman <ethan@stoneleaf.us>Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
gpshead added a commit that referenced this pull requestMay 3, 2023
…stHandler (GH-104067) (#104123)gh-104049: do not expose on-disk location from SimpleHTTPRequestHandler (GH-104067)Do not expose the local server's on-disk location from `SimpleHTTPRequestHandler` when generating a directory index. (unnecessary information disclosure)---------(cherry picked from commitc7c3a60)Co-authored-by: Ethan Furman <ethan@stoneleaf.us>Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
gpshead added a commit that referenced this pull requestMay 9, 2023
…stHandler (GH-104067) (#104119)gh-104049: do not expose on-disk location from SimpleHTTPRequestHandler (GH-104067)Do not expose the local server's on-disk location from `SimpleHTTPRequestHandler` when generating a directory index. (unnecessary information disclosure)---------(cherry picked from commitc7c3a60)Co-authored-by: Ethan Furman <ethan@stoneleaf.us>Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
ambv pushed a commit that referenced this pull requestMay 22, 2023
…tHandler (GH-104067) (#104121)Do not expose the local server's on-disk location from `SimpleHTTPRequestHandler` when generating a directory index. (unnecessary information disclosure)(cherry picked from commitc7c3a60)Co-authored-by: Ethan Furman <ethan@stoneleaf.us>Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
ambv pushed a commit that referenced this pull requestMay 22, 2023
…tHandler (GH-104067) (#104120)Do not expose the local server's on-disk location from `SimpleHTTPRequestHandler` when generating a directory index. (unnecessary information disclosure)(cherry picked from commitc7c3a60)Co-authored-by: Ethan Furman <ethan@stoneleaf.us>Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
The invalid escape sequence used in the tests makes some tests fail here.. I wonder why only I see it: |
lazka added a commit to msys2-contrib/cpython-mingw that referenced this pull requestJun 13, 2023
lazka added a commit to msys2-contrib/cpython-mingw that referenced this pull requestJun 14, 2023
carlosroman added a commit to DataDog/cpython that referenced this pull requestJun 22, 2023
* Post 3.8.16* [3.8] Update copyright years to 2023. (pythongh-100852)* [3.8] Update copyright years to 2023. (pythongh-100848).(cherry picked from commit11f9932)Co-authored-by: Benjamin Peterson <benjamin@python.org>* Update additional copyright years to 2023.Co-authored-by: Ned Deily <nad@python.org>* [3.8] Update copyright year in README (pythonGH-100863) (pythonGH-100867)(cherry picked from commit30a6cc4)Co-authored-by: Ned Deily <nad@python.org>Co-authored-by: HARSHA VARDHAN <75431678+Thunder-007@users.noreply.github.com>* [3.8] CorrectCVE-2020-10735 documentation (pythonGH-100306) (python#100698)(cherry picked from commit1cf3d78)(cherry picked from commit88fe8d7)Co-authored-by: Jeremy Paige <ucodery@gmail.com>Co-authored-by: Gregory P. Smith <greg@krypto.org>* [3.8] Bump Azure Pipelines to ubuntu-22.04 (pythonGH-101089) (python#101215)(cherry picked from commitc22a55c)Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>* [3.8]pythongh-100180: Update Windows installer to OpenSSL 1.1.1s (pythonGH-100903) (python#101258)*pythongh-101422: (docs) TarFile default errorlevel argument is 1, not 0 (pythonGH-101424)(cherry picked from commitea23271)Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>* [3.8]pythongh-95778: add doc missing in some places (pythonGH-100627) (python#101630)(cherry picked from commit4652182)* [3.8]pythongh-101283: Improved fallback logic for subprocess with shell=True on Windows (pythonGH-101286) (python#101710)Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>Co-authored-by: Steve Dower <steve.dower@microsoft.com>* [3.8]pythongh-101981: Fix Ubuntu SSL tests with OpenSSL (3.1.0-beta1) CI i… (python#102095)[3.8]pythongh-101981: Fix Ubuntu SSL tests with OpenSSL (3.1.0-beta1) CI issue (pythongh-102079)* [3.8]pythonGH-102306 Avoid GHA CI macOS test_posix failure by using the appropriate macOS SDK (pythonGH-102307)[3.8] Avoid GHA CI macOS test_posix failure by using the appropriate macOS SDK.* [3.8]pythongh-101726: Update the OpenSSL version to 1.1.1t (pythonGH-101727) (pythonGH-101752)FixesCVE-2023-0286 (High) and a couple of Medium security issues.https://www.openssl.org/news/secadv/20230207.txtCo-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Ned Deily <nad@python.org>* [3.8]pythongh-102627: Replace address pointing toward malicious web page (pythonGH-102630) (pythonGH-102667)(cherry picked from commit61479d4)Co-authored-by: Blind4Basics <32236948+Blind4Basics@users.noreply.github.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>* [3.8]pythongh-101997: Update bundled pip version to 23.0.1 (pythonGH-101998). (python#102244)(cherry picked from commit89d9ff0)* [3.8]pythongh-102950: Implement PEP 706 – Filter for tarfile.extractall (pythonGH-102953) (python#104548)Backport ofc8c3956* [3.8]pythongh-99889: Fix directory traversal security flaw in uu.decode() (pythonGH-104096) (python#104332)(cherry picked from commit0aeda29)Co-authored-by: Sam Carroll <70000253+samcarroll42@users.noreply.github.com>* [3.8]pythongh-104049: do not expose on-disk location from SimpleHTTPRequestHandler (pythonGH-104067) (python#104121)Do not expose the local server's on-disk location from `SimpleHTTPRequestHandler` when generating a directory index. (unnecessary information disclosure)(cherry picked from commitc7c3a60)Co-authored-by: Ethan Furman <ethan@stoneleaf.us>Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>* [3.8]pythongh-103935: Use `io.open_code()` when executing code in trace and profile modules (pythonGH-103947) (python#103954)Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>* [3.8]pythongh-68966: fix versionchanged in docs (pythonGH-105299)* [3.8] Update GitHub CI workflow for macOS. (pythonGH-105302)* [3.8]pythongh-105184: document that marshal functions can fail and need to be checked with PyErr_Occurred (pythonGH-105185) (python#105222)(cherry picked from commitee26ca1)Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>* [3.8]pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508) (pythonGH-104575) (pythonGH-104592) (python#104593) (python#104895)`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bitpythonGH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).I simplified the docs by eliding the state of the world explanatoryparagraph in this security release only backport. (people will seethat in the mainline /3/ docs)(cherry picked from commitd7f8a5f)(cherry picked from commit2f630e1)(cherry picked from commit610cc0a)(cherry picked from commitf48a96a)Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>Co-authored-by: Illia Volochii <illia.volochii@gmail.com>Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>* [3.8]pythongh-103142: Upgrade binary builds and CI to OpenSSL 1.1.1u (pythonGH-105174) (pythonGH-105200) (pythonGH-105205) (python#105370)Upgrade builds to OpenSSL 1.1.1u.Also updates _ssl_data_111.h from OpenSSL 1.1.1u, _ssl_data_300.h from 3.0.9.Manual edits to the _ssl_data_300.h file prevent it from removing anyexisting definitions in case those exist in some peoples builds and wereimportant (avoiding regressions during backporting).(cherry picked from commitede89af)(cherry picked from commite15de14)Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Ned Deily <nad@python.org>* Python 3.8.17* Post 3.8.17* Updated CI to build 3.8.17---------Co-authored-by: Łukasz Langa <lukasz@langa.pl>Co-authored-by: Benjamin Peterson <benjamin@python.org>Co-authored-by: Ned Deily <nad@python.org>Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>Co-authored-by: HARSHA VARDHAN <75431678+Thunder-007@users.noreply.github.com>Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Jeremy Paige <ucodery@gmail.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Steve Dower <steve.dower@python.org>Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>Co-authored-by: Éric <earaujo@caravan.coop>Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>Co-authored-by: Steve Dower <steve.dower@microsoft.com>Co-authored-by: Dong-hee Na <donghee.na@python.org>Co-authored-by: Blind4Basics <32236948+Blind4Basics@users.noreply.github.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>Co-authored-by: Pradyun Gedam <pradyunsg@gmail.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Sam Carroll <70000253+samcarroll42@users.noreply.github.com>Co-authored-by: Ethan Furman <ethan@stoneleaf.us>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>Co-authored-by: stratakis <cstratak@redhat.com>Co-authored-by: Illia Volochii <illia.volochii@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.