Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-90562: Update __class__ in function closures for dataclasses with slots=True#104038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
I'll close this, as it can still serve as a POC for the linked issue, but there's nothing further to do on this PR right now. |
Thanks,@wookie184. I'm going to use this basic approach in#90562. Although I did that implementation before I noticed this PR, I am going to grab some of your tests and credit you. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Opened as a draft as I haven't updated docs or added news yet.
This is similar to how attrs does it, which was mentioned in the issue.https://github.com/python-attrs/attrs/blob/7c44cfb3c196f547d351af44e411b43f65819714/src/attr/_make.py#L876-L897.
As well as attrs functionality, this also supports:
functools.wraps
There are some cases that are not supported:
functools.wraps
(or more precisely, don't have a__wrapped__
attribute which allows us to access the original function defined in the class).Note that since the
__class__
cell is shared between functions, these unsupported methodswill work if there is one occurence of a supported way of doing things. This is a bit of a gotcha, but I think if it's documented it should be acceptable.I made an attempt at getting an idea of what the effect of this on performance will be on existing code
Before:
[0.9140953719997924, 0.9357239580003807, 0.9163554130000193]
After:
[0.9437777250004729, 0.9911788059998798, 0.9630459829995743]
There is a difference, but I think it should be acceptable given it only affects dataclass creation.