Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-104018: disallow "z" format specifier in %-format of byte strings#104033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ringsPEP-0682 specified that %-formatting would not support the "z"specifier, but it was unintentionally allowed for a byte strings.Issue:python#104018
mdickinson approved these changesMay 1, 2023
Member
mdickinson left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. I'd regard this as a bugfix, and as such, I think it's safe to backport to 3.11.
Contributor
miss-islington commentedMay 1, 2023
Thanks@belm0 for the PR, and@mdickinson for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
bedevere-bot commentedMay 1, 2023
GH-104058 is a backport of this pull request to the3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 1, 2023
…rings (pythonGH-104033)PEP-0682 specified that %-formatting would not support the "z" specifier,but it was unintentionally allowed for bytes. This PR makes use of the "z"flag an error for %-formatting in a bytestring.Issue:pythonGH-104018---------(cherry picked from commit3ed8c88)Co-authored-by: John Belmonte <john@neggie.net>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
mdickinson pushed a commit that referenced this pull requestMay 1, 2023
…trings (GH-104033) (#104058)gh-104018: disallow "z" format specifier in %-format of byte strings (GH-104033)PEP-0682 specified that %-formatting would not support the "z" specifier,but it was unintentionally allowed for bytes. This PR makes use of the "z"flag an error for %-formatting in a bytestring.Issue:GH-104018---------(cherry picked from commit3ed8c88)Co-authored-by: John Belmonte <john@neggie.net>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
carljm added a commit to carljm/cpython that referenced this pull requestMay 1, 2023
* main: (463 commits)pythongh-104057: Fix direct invocation of test_super (python#104064)pythongh-87092: Expose assembler to unit tests (python#103988)pythongh-97696: asyncio eager tasks factory (python#102853)pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054)pythongh-104057: Fix direct invocation of test_module (pythonGH-104059)pythongh-100458: Clarify Enum.__format__() change of mixed-in types in the whatsnew/3.11.rst (pythonGH-100387)pythongh-104018: disallow "z" format specifier in %-format of byte strings (pythonGH-104033)pythongh-104016: Fixed off by 1 error in f string tokenizer (python#104047)pythonGH-103629: Update Unpack's repr in compliance with PEP 692 (python#104048)pythongh-102799: replace sys.exc_info by sys.exception in inspect and traceback modules (python#104032) Fix typo in "expected" word in few source files (python#104034)pythongh-103824: fix use-after-free error in Parser/tokenizer.c (python#103993)pythongh-104035: Do not ignore user-defined `__{get,set}state__` in slotted frozen dataclasses (python#104041)pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)pythongh-104036: Fix direct invocation of test_typing (python#104037)pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897) Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)pythongh-88496: Fix IDLE test hang on macOS (python#104025) Improve int test coverage (python#104024) ...
belm0 added a commit to belm0/cpython that referenced this pull requestMay 2, 2023
This is a cleanup missed in PRpython#104033.Please skip NEWS.
belm0 added a commit to belm0/cpython that referenced this pull requestMay 2, 2023
…oat()This is a cleanup overlooked in PRpython#104033.Please skip NEWS.
kumaraditya303 pushed a commit that referenced this pull requestMay 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 7, 2023
…oat() (pythonGH-104107)This is a cleanup overlooked in PRpythonGH-104033.(cherry picked from commit69621d1)Co-authored-by: John Belmonte <john@neggie.net>
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull requestMay 8, 2023
…oat() (python#104107)This is a cleanup overlooked in PRpython#104033.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PEP-0682 specified that %-formatting would not support the "z" specifier, but it was unintentionally allowed for a byte strings.