Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-103963: Make dis display names of args for intrinsics opcodes#104029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jkchandalia
Copy link
Contributor

@jkchandaliajkchandalia commentedMay 1, 2023•
edited by bedevere-bot
Loading

Make the dis module display the names of the args for opcodesCALL_INTRINSIC_*.

Fixes#103963

@jkchandalia
Copy link
ContributorAuthor

Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, a few comments. You'll also have to add a NEWS entry.

@jkchandalia
Copy link
ContributorAuthor

@iritkatriel@JelleZijlstra I've reviewed your comments and updated the PR. Please let me know if you see anything else or if I should convert to normal PR.

Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great!

@JelleZijlstra
Copy link
Member

I'll give Irit some time to take another look, but I think this is ready to merge.



/* Binary Functions: */
#define INTRINSIC_INVALID 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks like INTRINSIC_INVALID is defined twice?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Updated to differentiate between invalid for the twoCALL_INTRINSIC_* opcodes.

@iritkatrieliritkatriel marked this pull request as ready for reviewMay 2, 2023 17:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dis: Show names of intrinsics
4 participants
@jkchandalia@JelleZijlstra@iritkatriel@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp