Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-103978: avoid using 'class' as an identifier#103979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
carljm merged 2 commits intopython:mainfromcarljm:fixclass
Apr 28, 2023

Conversation

@carljm
Copy link
Member

@carljmcarljm commentedApr 28, 2023•
edited by bedevere-bot
Loading

Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Super,super minor... but maybe usecls instead ofklass for this?

It's a much more common name in our codebase... and I personally like it alot more. 🙃

carljm, JelleZijlstra, and Fidget-Spinner reacted with thumbs up emoji
@carljmcarljmenabled auto-merge (squash)April 28, 2023 18:51
@carljmcarljm merged commitebf97c5 intopython:mainApr 28, 2023
@carljmcarljm deleted the fixclass branchApril 28, 2023 19:21
@tacaswell
Copy link
Contributor

Thank you!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@brandtbucherbrandtbucherbrandtbucher approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'class' parameter name in headers breaks building C++ extensions

5 participants

@carljm@tacaswell@JelleZijlstra@brandtbucher@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp