Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-103092: Adapt _ctypes's PyCStgDict type to heap type#103932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedApr 27, 2023•
edited by bedevere-bot
Loading

Port PyCStgDict_Type to heap type.

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commentedApr 27, 2023•
edited
Loading

This probably fails because of the dict hacks inStructUnionType_new (wild guess).

@corona10corona10 self-requested a reviewApril 27, 2023 23:31
@kumaraditya303kumaraditya303force-pushed theisolate-ctypes/part2-take2 branch from11c91c9 to56fd7e9CompareMay 15, 2023 09:49
@kumaraditya303
Copy link
Contributor

kumaraditya303 commentedMay 30, 2023•
edited
Loading

While I am still trying to figure out where it breaks, you may proceed to port other simpler types (if there are any).

@vstinner
Copy link
Member

What's the status of this PR? Is it ready for review? It's still marked as a draft.

PyCStgDict_traverse(StgDictObject *self, visitproc visit, void *arg)
{
Py_VISIT(Py_TYPE(self));
Py_VISIT(self->proto);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe an extra visit to theproto member? TheCDataType_traverse function in _ctypes.c has an explicitPy_VISIT(dict->proto).

@erlend-aaslanderlend-aasland changed the titlegh-103092: Isolate _ctypes, part 2gh-103092: Adapt _ctypes.PyCStgDict_Type to heap typeJan 9, 2024
@erlend-aaslanderlend-aasland changed the titlegh-103092: Adapt _ctypes.PyCStgDict_Type to heap typegh-103092: Adapt _ctypes's PyCStgDict type to heap typeJan 9, 2024
@erlend-aasland
Copy link
ContributorAuthor

I don't have the bandwidth to follow up this right now; abandoning this PR.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@neoneneneoneneneonene left review comments

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303

@corona10corona10Awaiting requested review from corona10

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently will be requested when the pull request is marked ready for reviewericsnowcurrently is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@erlend-aasland@kumaraditya303@vstinner@neonene@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp