Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
GH-103906: Remove immortal refcounting in the interpreter#103909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
hauntsaninja approved these changesApr 27, 2023
Contributor
hauntsaninja left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hooray! Looks great
| } | ||
| elseif (Py_IsFalse(cond)) { | ||
| _Py_DECREF_NO_DEALLOC(cond); | ||
| if (Py_IsFalse(cond)) { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Will this cause a performance change, since formerlyIsTrue thenIsFalse, nowIsFalse thenIsTrue
Though this comparison is lightweight.
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Honestly, I doubt it.
bedevere-bot commentedApr 27, 2023
🤖 New build scheduled with the buildbot fleet by@brandtbucher for commitfd95518 🤖 If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
Member
sobolevn left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What about other places, likeModules/? Should it be done later?
Member
JelleZijlstra commentedApr 27, 2023
@sobolevn possibly, but it's best left to a different PR. In many places it's unlikely to make a significant difference, so it might not be worth the churn to make the change everywhere. |
MemberAuthor
brandtbucher commentedApr 29, 2023
Annoyingly, perf impact isneutral. However, it appears that the results are being pulledway down by a couple of known unstable benchmarks that should be unaffected by this change. I might try running them again tonight, just to see. (I still think this is worth doing, though, as it clearly removes unnecessary work from many hot code paths.) |
markshannon approved these changesMay 12, 2023
Member
markshannon left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Even if the performance change is negligible, this seems like a worthwhile cleanup.
Member
JelleZijlstra commentedMay 12, 2023
I noticed one more opportunity like this: in the |
bedevere-bot commentedMay 16, 2023
|
carljm added a commit to carljm/cpython that referenced this pull requestMay 17, 2023
* main: (26 commits)pythonGH-101520: Move tracemalloc functionality into core, leaving interface in Modules. (python#104508) typing: Add more tests for TypeVar (python#104571)pythongh-104572: Improve error messages for invalid constructs in PEP 695 contexts (python#104573) typing: Use PEP 695 syntax in typing.py (python#104553)pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (python#102508)pythongh-104469: Update README.txt for _testcapi (pythongh-104529)pythonGH-103092: isolate `_elementtree` (python#104561)pythongh-104050: Add typing to Argument Clinic converters (python#104547)pythonGH-103906: Remove immortal refcounting in the interpreter (pythonGH-103909)pythongh-87474: Fix file descriptor leaks in subprocess.Popen (python#96351)pythonGH-103092: isolate `pyexpat` (python#104506)pythongh-75367: Fix data descriptor detection in inspect.getattr_static (python#104517)pythongh-104050: Add more annotations to `Tools/clinic.py` (python#104544)pythongh-104555: Fix isinstance() and issubclass() for runtime-checkable protocols that use PEP 695 (python#104556)pythongh-103865: add monitoring support to LOAD_SUPER_ATTR (python#103866) CODEOWNERS: Assign new PEP 695 files to myself (python#104551)pythonGH-104510: Fix refleaks in `_io` base types (python#104516)pythongh-104539: Fix indentation error in logging.config.rst (python#104545)pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543)pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538) ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs) performancePerformance or resource usage sprint
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.