Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-70795: Rework RLock documentation#103853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
CAM-Gerlach merged 14 commits intopython:mainfromsamatjain:gh-70795-RLock-docs
May 22, 2024

Conversation

samatjain
Copy link
Contributor

@samatjainsamatjain commentedApr 25, 2023•
edited by bedevere-bot
Loading

Attempted to simultaneously reduce verbosity, while more descriptively describing behavior.

Fix links (RLock acquire/release previously linking to Lock acquire/release, seems like bad copy pasta).

Attempted to simultaneously reduce verbosity, while more descriptivelydescribing behavior.Fix links (RLock acquire/release previously linking to Lockacquire/release, seems like bad copy pasta).
@ghost
Copy link

ghost commentedApr 25, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@samatjain
Copy link
ContributorAuthor

cc@CAM-Gerlach thanks for draft review!

@CAM-GerlachCAM-Gerlach self-requested a reviewApril 25, 2023 22:34
@CAM-GerlachCAM-Gerlach added docsDocumentation in the Doc dir skip news needs backport to 3.11only security fixes labelsApr 25, 2023
gpshead
gpshead previously requested changesApr 25, 2023
Copy link
Member

@gpsheadgpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

some rewording suggestions.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Various suggested changes and fixed.

Standard reminder: You can directly apply all the suggestions you want in one go by going toFiles changed -> ClickingAdd to batch on each suggestion -> When done, clickingCommit

samatjainand others added2 commitsApril 25, 2023 16:39
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A couple followup comments

samatjainand others added2 commitsApril 25, 2023 18:04
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM from my side; thanks@samatjain ! I'll leave it to@gpshead to re-review the content.

samatjain reacted with heart emoji
@CAM-GerlachCAM-Gerlach marked this pull request as ready for reviewApril 26, 2023 01:18
@serhiy-storchakaserhiy-storchaka added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes and removed needs backport to 3.11only security fixes labelsMay 9, 2024
@CAM-GerlachCAM-Gerlach dismissedgpshead’sstale reviewMay 22, 2024 19:47

All comments appear to be addressed and no further were made after several months

@CAM-GerlachCAM-Gerlach merged commit2fbea81 intopython:mainMay 22, 2024
@miss-islington-app
Copy link

Thanks@samatjain for the PR, and@CAM-Gerlach for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 22, 2024
Attempted to simultaneously reduce verbosity, while more descriptivelydescribing behavior.Fix links (RLock acquire/release previously linking to Lockacquire/release, seems like bad copy pasta).Add a seealso for with-locks.Switch section to use bullet points.---------(cherry picked from commit2fbea81)Co-authored-by: uıɐɾ ʞ ʇɐɯɐs <_@skj.io>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 22, 2024
Attempted to simultaneously reduce verbosity, while more descriptivelydescribing behavior.Fix links (RLock acquire/release previously linking to Lockacquire/release, seems like bad copy pasta).Add a seealso for with-locks.Switch section to use bullet points.---------(cherry picked from commit2fbea81)Co-authored-by: uıɐɾ ʞ ʇɐɯɐs <_@skj.io>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@bedevere-app
Copy link

GH-119436 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 22, 2024
@bedevere-app
Copy link

GH-119437 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelMay 22, 2024
CAM-Gerlach added a commit that referenced this pull requestMay 22, 2024
gh-70795: Rework RLock documentation (GH-103853)Attempted to simultaneously reduce verbosity, while more descriptivelydescribing behavior.Fix links (RLock acquire/release previously linking to Lockacquire/release, seems like bad copy pasta).Add a seealso for with-locks.Switch section to use bullet points.---------(cherry picked from commit2fbea81)Co-authored-by: uıɐɾ ʞ ʇɐɯɐs <_@skj.io>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
gpshead pushed a commit that referenced this pull requestMay 22, 2024
gh-70795: Rework RLock documentation (GH-103853)Attempted to simultaneously reduce verbosity, while more descriptivelydescribing behavior.Fix links (RLock acquire/release previously linking to Lockacquire/release, seems like bad copy pasta).Add a seealso for with-locks.Switch section to use bullet points.---------(cherry picked from commit2fbea81)Co-authored-by: uıɐɾ ʞ ʇɐɯɐs <_@skj.io>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
Attempted to simultaneously reduce verbosity, while more descriptivelydescribing behavior.Fix links (RLock acquire/release previously linking to Lockacquire/release, seems like bad copy pasta).Add a seealso for with-locks.Switch section to use bullet points.---------Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gpsheadgpsheadAwaiting requested review from gpshead

@CAM-GerlachCAM-GerlachAwaiting requested review from CAM-Gerlach

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@samatjain@bedevere-bot@gpshead@CAM-Gerlach@serhiy-storchaka@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp