Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-102950: Adjust tarfile filter tests for systems that don't set the sticky bit#103831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the endis enough.
I tried the patch on Solaris and the test suite is green again. Thanks! |
Hm, Sir Bedevere got stuck figuring out whether the pull request title starts with |
encukou added a commit to encukou/cpython that referenced this pull requestApr 25, 2023
…et the sticky bit (pythonGH-103831)Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end isenough.Backport ofc8c3956
mcepl pushed a commit to openSUSE-Python/cpython that referenced this pull requestMay 3, 2023
…et the sticky bit (pythonGH-103831)Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end isenough.Backport ofc8c3956
encukou added a commit to encukou/cpython that referenced this pull requestMay 11, 2023
…et the sticky bit (pythonGH-103831)Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end isenough.Backport ofc8c3956
encukou added a commit to encukou/cpython that referenced this pull requestMay 11, 2023
…et the sticky bit (pythonGH-103831)Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end isenough.Backport ofc8c3956
encukou added a commit to encukou/cpython that referenced this pull requestMay 16, 2023
…et the sticky bit (pythonGH-103831)Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end isenough.Backport ofc8c3956
encukou added a commit to encukou/cpython that referenced this pull requestMay 30, 2023
…et the sticky bit (pythonGH-103831)Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end isenough.Backport ofc8c3956
mcepl pushed a commit to openSUSE-Python/cpython that referenced this pull requestMar 28, 2024
…et the sticky bit (pythonGH-103831)Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end isenough.Backport ofc8c3956
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove expilcit
type=tarfile.DIRTYPE, the slash at the end is enough.@kulikjak, could you check this on a Solaris or FreeBSD box?