Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-103592: Add tests ofLiteral withEnum andUnion ofLiterals#103706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AlexWaygood merged 1 commit intopython:mainfromsobolevn:issue-103592
Apr 23, 2023

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commentedApr 23, 2023•
edited by bedevere-bot
Loading

These tests should catch theoretical future regressions similar to ones described in#103592

@AlexWaygoodAlexWaygood merged commit5041c2b intopython:mainApr 23, 2023
@miss-islington
Copy link
Contributor

Thanks@sobolevn for the PR, and@AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 23, 2023
…iteral`s (pythonGH-103706)(cherry picked from commit5041c2b)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-103720 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelApr 23, 2023
@AlexWaygood
Copy link
Member

@sobolevn, are you up for backporting these tests totyping_extensions as well?

AlexWaygood pushed a commit that referenced this pull requestApr 23, 2023
…Literal`s (GH-103706) (#103720)gh-103592: Add tests of `Literal` with `Enum` and `Union` of `Literal`s (GH-103706)(cherry picked from commit5041c2b)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@sobolevn
Copy link
MemberAuthor

sobolevn commentedApr 23, 2023•
edited
Loading

Now I realized that I've missed| unions in this PR. Can I please add one more PR with an extra test totest_types?

@AlexWaygood Yeah, sure. Will do tomorrow.

AlexWaygood reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dirtopic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn@miss-islington@bedevere-bot@AlexWaygood@JelleZijlstra
[8]ページ先頭
©2009-2025 Movatter.jp