Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-103685: Fix tkinter.Menu.index() for Tk 8.7#103686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
terryjreedy merged 7 commits intopython:mainfromchrstphrchvz:patch-103685
Apr 24, 2023

Conversation

chrstphrchvz
Copy link
Contributor

@chrstphrchvzchrstphrchvz commentedApr 22, 2023
edited by bedevere-bot
Loading

@terryjreedy
Copy link
Member

Christopher: Add blurb with something like "Make tkinter.Menu.index('none') continue to work in tk 8.7."

@serhiy-storchaka Do we consider tkinter failures due to tcl/tk changes to be bugs, such that fixes should be backported? I am thinking so and plan to merge and backport unless you say something.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@serhiy-storchaka
Copy link
Member

I agree that it should be backported.

@chrstphrchvz Do existing tests cover this case? Or a new test is needed?

@serhiy-storchakaserhiy-storchaka added the needs backport to 3.11only security fixes labelApr 23, 2023
@chrstphrchvz
Copy link
ContributorAuthor

@chrstphrchvz Do existing tests cover this case? Or a new test is needed?

I did not notice the error in any existing test.test_tkinter tests, so I have added a test for this. The error does prevent IDLE from launching (at least on Aqua), though.

This PR is probably one of the smaller and easier to understand changes needed for Tk 8.7, but in practice it is likely not useful without first addressing e.g.#103194, so presumably there would be more to backport.

@terryjreedyterryjreedy marked this pull request as ready for reviewApril 23, 2023 20:49
@terryjreedy
Copy link
Member

Properly testing tkinter, etc, with 8.7 requires a buildbot that installs the latest 8.7, which we don't have yet. I have no idea whether the linux x simulator can simulate 8.7 yet.

Again, please add a blurb. Perhaps "Make tkinter.Menu.index('none') work in tcl/tk versions being developed." is slightly better that what i wrote above.

@terryjreedyterryjreedy merged commitf0ed293 intopython:mainApr 24, 2023
@miss-islington
Copy link
Contributor

Thanks@chrstphrchvz for the PR, and@terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 24, 2023
---------(cherry picked from commitf0ed293)Co-authored-by: Christopher Chavez <chrischavez@gmx.us>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
@bedevere-bot
Copy link

GH-103734 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelApr 24, 2023
@chrstphrchvzchrstphrchvz deleted the patch-103685 branchApril 24, 2023 01:34
terryjreedy added a commit that referenced this pull requestApr 24, 2023
…03734)gh-103685: Fix tkinter.Menu.index() for Tk 8.7 (GH-103686)---------(cherry picked from commitf0ed293)Co-authored-by: Christopher Chavez <chrischavez@gmx.us>Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@terryjreedyterryjreedyterryjreedy approved these changes

Assignees
No one assigned
Labels
stdlibPython modules in the Lib dirtopic-tkinter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@chrstphrchvz@terryjreedy@serhiy-storchaka@miss-islington@bedevere-bot@arhadthedev

[8]ページ先頭

©2009-2025 Movatter.jp