Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-103673: Add missing ForkingUnixStreamServer and ForkingUnixDatagramServer socketservers#103674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 11 commits intopython:mainfromjb2170:gh-103673
Apr 24, 2023

Conversation

@jb2170
Copy link
Contributor

@jb2170jb2170 commentedApr 22, 2023
edited by bedevere-bot
Loading

@sobolevnsobolevn changed the titlegh-103673gh-103673: Add missing ForkingUnixStreamServer and ForkingUnixDatagramServer socketserversApr 22, 2023
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot for the feature suggestion and the implementation.

Please, to increase the chances of this feature been accepted, add tests and docs: when to use these new types of servers, how, etc.

jb2170 and gpshead reacted with thumbs up emoji
@gpsheadgpshead self-assigned thisApr 23, 2023
gpsheadand others added6 commitsApril 23, 2023 12:44
admittedly other existing lines don't always do this. this module is very old code.Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@jb2170
Copy link
ContributorAuthor

add tests

I have now updatedLib/test/test_socketserver.py to include the appropriate tests. Turns out it was defining its ownForkingUnix{Stream,Datagram}Server within the test file exactly as we are adding tosocketserver, who would've guessed hahaha.

and docs

The current docs already describe in detail theThreadingMixIn andForkingMixIn, when to use them etc. The only thing that really needed adding was the mentions of the new servers at the'These classes are pre-defined using the mix-in classes' section. The existing documentation only mentions the{Forking,Threading}{TCP,UDP}Server classes once in this section, and the new docs in this PR are consistent with this; the documentation seems enough.

Thanks for the intermediary commits. The PR is now up-to-date again with main and is conflict free.

gpshead reacted with laugh emoji

@gpsheadgpsheadenabled auto-merge (squash)April 24, 2023 22:06
@gpsheadgpshead merged commitd94b3a6 intopython:mainApr 24, 2023
@jb2170jb2170 deleted the gh-103673 branchApril 24, 2023 22:48
carljm added a commit to carljm/cpython that referenced this pull requestApr 24, 2023
* main:pythongh-103801: Tools/wasm linting and formatting (python#103796)pythongh-103673: Add missing ForkingUnixStreamServer and ForkingUnixDatagramServer socketservers (python#103674)pythongh-95795: Move types.next_version_tag to PyInterpreterState (pythongh-102343)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn left review comments

@gpsheadgpsheadgpshead approved these changes

Assignees

@gpsheadgpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jb2170@gpshead@sobolevn@bedevere-bot@arhadthedev

[8]ページ先頭

©2009-2025 Movatter.jp