NotificationsYou must be signed in to change notification settings
Fork32k
Star67.2k

gh-103596: [Enum] do not shadow mixed-in methods/attributes#103600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ethanfurman merged 2 commits intopython:mainfromethanfurman:enum-no_shadow

Apr 18, 2023

Merged

gh-103596: [Enum] do not shadow mixed-in methods/attributes#103600

ethanfurman merged 2 commits intopython:mainfromethanfurman:enum-no_shadow

Apr 18, 2023

Conversation

Copy link

Member

ethanfurman commentedApr 17, 2023•
edited
Loading

For example:

class Book(StrEnum):    title = auto()    author = auto()    desc = auto()Book.author.desc is Book.desc

but

Book.author.title() == 'Author'

Using upper-case member names avoids any possible confusion.

Issue:[Enum] attributes of mixed-in classes can be shadowed by other members #103596

do not shadow mixed-in methods/attributes

b1b5392

For example:    class Book(StrEnum):        title = auto()        author = auto()        desc = auto()    Book.author.desc is Book.descbut    Book.author.title() == 'Author'Using upper-case member names means this isn't an issue in practice.

ethanfurman added type-bug

An unexpected behavior, bug, or error

type-feature

A feature request or enhancement

stdlib

Python modules in the Lib dir

3.12only security fixes labels

Apr 17, 2023

ethanfurman self-assigned this

Apr 17, 2023

bedevere-bot mentioned this pull request

Apr 17, 2023

[Enum] attributes of mixed-in classes can be shadowed by other members#103596

Closed

bedevere-bot added the awaiting core review label

Apr 17, 2023

Copy link

MemberAuthor

ethanfurman commentedApr 17, 2023

Note that performance is only impacted when there is a name clash between member and existing attribute/method.

samypr100 reviewed

Apr 18, 2023

View reviewed changes

Doc/howto/enum.rst OutdatedShow resolvedHide resolved

fix typo

0d06493

Co-authored-by: samypr100 <3933065+samypr100@users.noreply.github.com>

ethanfurman merged commit700ec65 intopython:main

Apr 18, 2023

bedevere-bot removed the awaiting core review label

Apr 18, 2023

ethanfurman deleted the enum-no_shadow branch

April 18, 2023 23:19

samypr100 mentioned this pull request

Apr 19, 2023

Python 3.11 StrEnum error when member is named "title"python/mypy#14494

Closed

carljm added a commit to carljm/cpython that referenced this pull request

Apr 20, 2023

Merge branch 'main' into superopt

5c0a21c

* main: (24 commits)pythongh-98040: Move the Single-Phase Init Tests Out of test_imp (pythongh-102561)pythongh-83861: Fix datetime.astimezone() method (pythonGH-101545)pythongh-102856: Clean some of the PEP 701 tokenizer implementation (python#103634)pythongh-102856: Skip test_mismatched_parens in WASI builds (python#103633)pythongh-102856: Initial implementation of PEP 701 (python#102855)pythongh-103583: Add ref. dependency between multibytecodec modules (python#103589)pythongh-83004: Harden msvcrt further (python#103420)pythonGH-88342: clarify that `asyncio.as_completed` accepts generators yielding tasks (python#103626)pythongh-102778: IDLE - make sys.last_exc available in Shell after traceback (python#103314)pythongh-103582: Remove last references to `argparse.REMAINDER` from docs (python#103586)pythongh-103583: Always pass multibyte codec structs as const (python#103588)pythongh-103617: Fix compiler warning in _iomodule.c (python#103618)pythongh-103596: [Enum] do not shadow mixed-in methods/attributes (pythonGH-103600)pythonGH-100530: Change the error message for non-class class patterns (pythonGH-103576)pythongh-95299: Remove lingering setuptools reference in installer scripts (pythonGH-103613)  [Doc] Fix a typo in optparse.rst (python#103504)pythongh-101100: Fix broken reference `__format__` in `string.rst` (python#103531)pythongh-95299: Stop installing setuptools as a part of ensurepip and venv (python#101039)pythonGH-103484: Docs: add linkcheck allowed redirects entries for most cases (python#103569)pythongh-67230: update whatsnew note for csv changes (python#103598)  ...