Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-103088: Fix test error message#103500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 1 commit intopython:mainfromZabolekar:fix-windows-scripts-issue-103088
Apr 13, 2023
Merged

gh-103088: Fix test error message#103500

zooba merged 1 commit intopython:mainfromZabolekar:fix-windows-scripts-issue-103088
Apr 13, 2023

Conversation

Zabolekar
Copy link
Contributor

@ZabolekarZabolekar commentedApr 13, 2023
edited by bedevere-bot
Loading

@arhadthedev
Copy link
Member

Triggering the buildbots to get logs with the new message.

@arhadthedevarhadthedev added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 13, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@arhadthedev for commitbf3c063 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 13, 2023
@arhadthedev
Copy link
Member

The tests are done:

======================================================================FAIL: test_activate_shell_script_has_no_dos_newlines (test.test_venv.BasicTest.test_activate_shell_script_has_no_dos_newlines)Test that the `activate` shell script contains no CR LF.----------------------------------------------------------------------Traceback (most recent call last):  File "D:\buildarea\pull_request.bolen-windows10\build\Lib\test\test_venv.py", line 628, in test_activate_shell_script_has_no_dos_newlines    self.assertFalse(line.endswith(b'\r\n'), error_message)AssertionError: True is not false : CR LF found in line 1----------------------------------------------------------------------

@arhadthedev
Copy link
Member

According tohttps://git-scm.com/docs/gitattributes#_text, we need to check ifcore.autocrlf is set ingit config on Windows because it overrides.gitattributes.

Zabolekar reacted with thumbs up emojizooba reacted with thumbs down emoji

@zooba
Copy link
Member

It only overrides the value ofcore.eol being used as the default, which is not what is happening here. We've explicitly set the line ending for the file, we just need anyone who's checked it out in the past to delete it and check it out again (tested on my own Windows machine, which hascore.autocrlf set).

If we can't find a way to force the buildbots to do a clean checkout, instead of reusing their existing one, then we probably need to ping all the owners to log in and do it manually.

@zooba
Copy link
Member

The buildbot results look good (the expected failure), so merging this. Buildbot discussion back to#103088 please.

@zoobazooba merged commit4307fea intopython:mainApr 13, 2023
carljm added a commit to carljm/cpython that referenced this pull requestApr 13, 2023
* main:pythongh-103479: [Enum] require __new__ to be considered a data type (pythonGH-103495)pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494)pythonGH-103488: Use return-offset, not yield-offset. (pythonGH-103502)pythongh-103088: Fix test_venv error message to avoid bytes/str warning (pythonGH-103500)pythonGH-103082: Turn on branch events for FOR_ITER instructions. (python#103507)pythongh-102978: Fix mock.patch function signatures for class and staticmethod decorators (python#103228)pythongh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending (python#103463)pythongh-95299: Rework test_cppext.py to not invoke setup.py directly (python#103316)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@Zabolekar@arhadthedev@bedevere-bot@zooba

[8]ページ先頭

©2009-2025 Movatter.jp