Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.1k
Comments
gh-67230: document new csv quoting modes in whatsnew (gh-103491)#103491
gh-67230: document new csv quoting modes in whatsnew (gh-103491)#103491merwok merged 3 commits intopython:mainfrom
Conversation
Add blurb about changes to :mod:`csv`.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
bedevere-bot commentedApr 12, 2023
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Uh oh!
There was an error while loading.Please reload this page.
smontanaro commentedApr 13, 2023
This interface is horrible. I see a change was rewuested by@merwok but can't see what it is. So... I have made the requested changes; please review again. |
bedevere-bot commentedApr 13, 2023
Thanks for making the requested changes! @merwok: please review the changes made to this pull request. |
merwok commentedApr 13, 2023
Ah! «requested changes» is a review status (others are «approved» and «commented») |
samwyse commentedApr 13, 2023
@smontanaro looks good! I tried to do this myself last night, but I was at my kid's soccer practice and discovered that the official iPhone GitHub app does not have all the functionality of the web GUI. 😢 |
smontanaro commentedApr 13, 2023 via email
@smontanaro <https://github.com/smontanaro> looks good! I tried to do this myself last night, but I was at my kid's soccer practice and discovered that the official iPhone GitHub app does not have all the functionality of the web GUI. 😢 Funny thing. I discovered the same thing about the Android app. … Message ID: ***@***.***> |
chaeynz commentedOct 6, 2023
@smontanaro were you responsible for the csv.QUOTE_NULL? You're an absolute legend! |
smontanaro commentedOct 6, 2023
Not exactly. Someone else suggested it years ago. I tend to catch most proposed changes to the csv module... |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Add blurb about recent change to csv.