Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

gh-67230: document new csv quoting modes in whatsnew (gh-103491)#103491

Merged
merwok merged 3 commits intopython:mainfrom
smontanaro:patch-4
Apr 13, 2023
Merged

gh-67230: document new csv quoting modes in whatsnew (gh-103491)#103491
merwok merged 3 commits intopython:mainfrom
smontanaro:patch-4

Conversation

@smontanaro
Copy link
Contributor

@smontanarosmontanaro commentedApr 12, 2023
edited by merwok
Loading

Add blurb about recent change to csv.

Add blurb about changes to :mod:`csv`.
@bedevere-botbedevere-bot added docsDocumentation in the Doc dir skip news awaiting review labelsApr 12, 2023
@merwokmerwok changed the titleUpdate 3.12.rstbpo-67230: document new csv quoting modes in whatsnewApr 12, 2023
@merwokmerwok changed the titlebpo-67230: document new csv quoting modes in whatsnewgh-67230: document new csv quoting modes in whatsnewApr 12, 2023
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@merwokmerwok self-assigned thisApr 12, 2023
@smontanaro
Copy link
ContributorAuthor

This interface is horrible. I see a change was rewuested by@merwok but can't see what it is. So...

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@merwok: please review the changes made to this pull request.

@merwok
Copy link
Member

I see a change was requested by merwok but can't see what it is. So...

Ah! «requested changes» is a review status (others are «approved» and «commented»)
Comments can be standalone or part of a review; I used the latter mode, made a few comments (some being change suggestions) and published my review with the «changes requested» status. Then I applied some of my suggested changes directly. So you saw «changes requested», some hidden comments («resolved» by the application of the suggestion), and one comment about the wording.

@merwokmerwok changed the titlegh-67230: document new csv quoting modes in whatsnewgh-67230: document new csv quoting modes in whatsnew (gh-103491)Apr 13, 2023
@merwokmerwok merged commitfb38c1b intopython:mainApr 13, 2023
@samwyse
Copy link
Contributor

@smontanaro looks good! I tried to do this myself last night, but I was at my kid's soccer practice and discovered that the official iPhone GitHub app does not have all the functionality of the web GUI. 😢

@smontanaro
Copy link
ContributorAuthor

smontanaro commentedApr 13, 2023 via email

@smontanaro <https://github.com/smontanaro> looks good! I tried to do this myself last night, but I was at my kid's soccer practice and discovered that the official iPhone GitHub app does not have all the functionality of the web GUI. 😢
Funny thing. I discovered the same thing about the Android app.
Message ID: ***@***.***>

aisk pushed a commit to aisk/cpython that referenced this pull requestApr 18, 2023
@chaeynz
Copy link

@smontanaro were you responsible for the csv.QUOTE_NULL?

You're an absolute legend!
I am working a project where I need exactly this, thank you so much! :)

@smontanaro
Copy link
ContributorAuthor

Not exactly. Someone else suggested it years ago. I tend to catch most proposed changes to the csv module...

KNGSJ

This comment was marked as off-topic.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@merwokmerwokAwaiting requested review from merwok

1 more reviewer

@KNGSJKNGSJKNGSJ left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@merwokmerwok

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@smontanaro@bedevere-bot@merwok@samwyse@chaeynz@KNGSJ

[8]ページ先頭

©2009-2026 Movatter.jp