Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending#103463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

alisaifee
Copy link
Contributor

@alisaifeealisaifee commentedApr 12, 2023•
edited
Loading

Description

When the payload used withSelectorSocketTransport.writelines is too large to write in one call to eithersocket.send orsocket.sendmsg the remaining buffer needs to be handled by registering a write handler.

Related Pull Request / Issue

Includes two failing tests that demonstrate a bugwhere if the data passed to writelines can't be sentin one shot, the remaining buffer isn't written sincethere is no registered write handler
If all the data in the buffer can't be written immediatelyschedule a writer to handle the remaining data.
@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@ghost
Copy link

ghost commentedApr 12, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@alisaifeealisaifee changed the titlegh-103462: Ensure SelectorSocketTransport.writelines schedules a writer when data is still pendinggh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pendingApr 12, 2023
When the platform (windows) doesn't support itskip tests for writelines using sendmsg
@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

alisaifee reacted with thumbs up emoji

Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, Can you add a news entry? Thanks

alisaifee reacted with thumbs up emoji
@alisaifee
Copy link
ContributorAuthor

LGTM, Can you add a news entry? Thanks

done!

@kumaraditya303kumaraditya303 merged commit19d2639 intopython:mainApr 13, 2023
carljm added a commit to carljm/cpython that referenced this pull requestApr 13, 2023
* main:pythongh-103479: [Enum] require __new__ to be considered a data type (pythonGH-103495)pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494)pythonGH-103488: Use return-offset, not yield-offset. (pythonGH-103502)pythongh-103088: Fix test_venv error message to avoid bytes/str warning (pythonGH-103500)pythonGH-103082: Turn on branch events for FOR_ITER instructions. (python#103507)pythongh-102978: Fix mock.patch function signatures for class and staticmethod decorators (python#103228)pythongh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending (python#103463)pythongh-95299: Rework test_cppext.py to not invoke setup.py directly (python#103316)
aisk pushed a commit to aisk/cpython that referenced this pull requestApr 18, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling SelectorSocketTransport.writelines with a very large payload doesn't get completely written to the socket
3 participants
@alisaifee@bedevere-bot@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp