NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

gh-103180: Add CI timeouts to all GitHub Actions jobs#103437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

hugovk merged 1 commit intopython:mainfromsobolevn:issue-103180

Apr 14, 2023

Merged

gh-103180: Add CI timeouts to all GitHub Actions jobs#103437

hugovk merged 1 commit intopython:mainfromsobolevn:issue-103180

Apr 14, 2023

Conversation

Copy link

Member

sobolevn commentedApr 11, 2023•
edited
Loading

See#103180 (comment) on why I used the numbers I used.

Docs:https://docs.github.com/ru/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes

Issue:Add a timeout to CI builds #103180

pythongh-103180: Add CI timeouts to all GtiHub Actions jobs

66f638f

sobolevn requested review fromezio-melotti andhugovk ascode owners

April 11, 2023 09:22

bedevere-bot mentioned this pull request

Apr 11, 2023

Add a timeout to CI builds#103180

Closed

bedevere-bot added the awaiting review label

Apr 11, 2023

sobolevn added skip news buildThe build process and cross-build labels

Apr 11, 2023

sobolevn changed the title~~gh-103180: Add CI timeouts to all GtiHub Actions jobs~~gh-103180: Add CI timeouts to all GitHub Actions jobs

Apr 11, 2023

hugovk approved these changes

Apr 11, 2023

View reviewed changes

Copy link

Member

hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the analysis at#103180 (comment).

We could probably skip timeouts for the short ones: timeouts tend to occur in the more complex and therefore slower ones, but I'm also fine adding them just in case.

bedevere-bot added awaiting merge and removed awaiting review labels

Apr 11, 2023

This comment was marked as spam.

Copy link

MemberAuthor

sobolevn commentedApr 11, 2023

@Ismaelkadir sorry, I don't understand your message :(

This comment was marked as spam.

hauntsaninja approved these changes

Apr 14, 2023

View reviewed changes

Copy link

Contributor

hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for doing this!

hugovk merged commitbe8903e intopython:main

Apr 14, 2023

bedevere-bot removed the awaiting merge label

Apr 14, 2023

hugovk added the needs backport to 3.11only security fixes label

Apr 14, 2023

Copy link

Contributor

miss-islington commentedApr 14, 2023

Thanks@sobolevn for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

Copy link

Contributor

miss-islington commentedApr 14, 2023

Sorry,@sobolevn and@hugovk, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker be8903eb9d66ef1229f93a3a6036aeafc3bb0bda 3.11

miss-islington assignedhugovk

Apr 14, 2023

Copy link

MemberAuthor

sobolevn commentedApr 14, 2023

Do you want me to backport this to 3.11 as well?

Copy link

Member

hugovk commentedApr 14, 2023

Yes please, could be useful there too :)

carljm added a commit to carljm/cpython that referenced this pull request

Apr 14, 2023

Merge branch 'main' into superopt

64da49f

* main:pythongh-103532: Remove TKINTER_PROTECT_LOADTK code (pythonGH-103535)pythongh-103180: Add CI timeouts to all GitHub Actions jobs (python#103437)  Remove double space in import error message (python#103458)  ipaddress: Remove non-existent ip_str param from docstring (python#103461)  Fix syntax typo in isolating extensions doc (python#103516)pythongh-103406: Modernize pos-only arguments usage in `test_signature` (python#103407)  Proofread howto/perf_profiling.rst (python#103530)  Fix unused functions warnings in instrumentation.c (pythonGH-103515)

sobolevn added a commit to sobolevn/cpython that referenced this pull request

Apr 14, 2023

[3.11]pythongh-103180: Add CI timeouts to all GitHub Actions jobs (p…

f7e8ca1

…ythonGH-103437).(cherry picked from commitbe8903e)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

Copy link

bedevere-bot commentedApr 14, 2023

GH-103543 is a backport of this pull request to the3.11 branch.

bedevere-bot removed the needs backport to 3.11only security fixes label

Apr 14, 2023

carljm added a commit to carljm/cpython that referenced this pull request

Apr 14, 2023

Merge branch 'superopt' into superopt_spec

b73cff0

* superopt:  fix incompatible types  update generated cases  don't unnecessarily re-find args in error case  Apply suggestions from code reviewpythongh-103532: Remove TKINTER_PROTECT_LOADTK code (pythonGH-103535)pythongh-103180: Add CI timeouts to all GitHub Actions jobs (python#103437)  Remove double space in import error message (python#103458)  ipaddress: Remove non-existent ip_str param from docstring (python#103461)  Fix syntax typo in isolating extensions doc (python#103516)pythongh-103406: Modernize pos-only arguments usage in `test_signature` (python#103407)  Proofread howto/perf_profiling.rst (python#103530)  Fix unused functions warnings in instrumentation.c (pythonGH-103515)