Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-83004: Harden winreg init#103386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-83004: Harden winreg init#103386
Uh oh!
There was an error while loading.Please reload this page.
Conversation
erlend-aasland commentedApr 10, 2023
@zooba, I'm landing this later tonight. |
| ADD_INT(REG_FULL_RESOURCE_DESCRIPTOR); | ||
| ADD_INT(REG_RESOURCE_REQUIREMENTS_LIST); | ||
| #undef ADD_INT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we undef theADD_KEY here also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes ideally, but not worth a separate PR, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Trying to merge this to#103250 , I'll add it is this PR.
Uh oh!
There was an error while loading.Please reload this page.