Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-103357: Add logging.Formater defaults support to logging.config fileConfig and dictConfig#103359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vsajip merged 4 commits intopython:mainfrombharel:add-defaults-logging-config
Apr 12, 2023

Conversation

@bharel
Copy link
Contributor

@bharelbharel commentedApr 8, 2023•
edited by bedevere-bot
Loading

Added the support for the defaults parameter, tests suite runs well.

@ghost
Copy link

ghost commentedApr 8, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@arhadthedevarhadthedev added the stdlibStandard Library Python modules in the Lib/ directory labelApr 8, 2023
@arhadthedev
Copy link
Member

@vsajip (as a logging moduleexpert)

@vsajipvsajip merged commit8f54302 intopython:mainApr 12, 2023
@vsajipvsajip added needs backport to 3.10only security fixes needs backport to 3.11only security fixes labelsApr 12, 2023
@miss-islington
Copy link
Contributor

Thanks@bharel for the PR, and@vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks@bharel for the PR, and@vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@bharel and@vsajip, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 8f54302ab49a07e857843f1a551db5ddb536ce56 3.11

@miss-islington
Copy link
Contributor

Sorry@bharel and@vsajip, I had trouble checking out the3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker 8f54302ab49a07e857843f1a551db5ddb536ce56 3.10

@vsajipvsajip removed the needs backport to 3.10only security fixes labelApr 12, 2023
@vsajip
Copy link
Member

Actually 3.10 is now security-fixes only.

bharel reacted with thumbs up emoji

@bharelbharel deleted the add-defaults-logging-config branchApril 13, 2023 03:57
@bharel
Copy link
ContributorAuthor

bharel commentedApr 13, 2023•
edited
Loading

@vsajip Thanks for the merge 😄
Why are we adding to 3.11? Is this technically a bug fix or a new feature? I'm guessing you took it as a bug fix, but I saw it as a feature. Keep in mind that the Python version I've set in the docsreference 3.12, and must be changed to 3.11.3/4 if so.

@vsajip
Copy link
Member

vsajip commentedApr 13, 2023•
edited
Loading

You're right, it is a new feature - I wasn't thinking clearly. Let's leave it and not backport.

bharel reacted with heart emoji

@arhadthedevarhadthedev removed the needs backport to 3.11only security fixes labelApr 13, 2023
aisk pushed a commit to aisk/cpython that referenced this pull requestApr 18, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Assignees

@vsajipvsajip

Labels

stdlibStandard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bharel@arhadthedev@miss-islington@vsajip@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp