Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-103285: Rewrite _splitlines_no_ff to improve performance#103307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@gaogaotiantian
Copy link
Member

@gaogaotiantiangaogaotiantian commentedApr 6, 2023•
edited by bedevere-bot
Loading

jingxu94 reacted with thumbs up emoji
@arhadthedevarhadthedev added performancePerformance or resource usage stdlibStandard Library Python modules in the Lib/ directory labelsApr 6, 2023
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

@gaogaotiantian
Copy link
MemberAuthor

@isidentical hi could you take a look at the change when you have some time? Thanks!

@isidentical
Copy link
Member

This was something I complained a lot in the past, thanks for taking a stab at it.

@gaogaotiantian
Copy link
MemberAuthor

No problem :) Let me know if you need me to change anything.

@gaogaotiantiangaogaotiantianforce-pushed theast-sourcefile-optimization branch from6e7e73a to14a73a5CompareApril 18, 2023 21:15
Copy link
Member

@isidenticalisidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great, tested a bunch of scenarios involving consecutive\rs etc. and seems to imitate the behavior of the old implementation exactly. With the additional tests, this should be good to go!

@gaogaotiantian
Copy link
MemberAuthor

Do we need the approval from@sobolevn for auto merge to take effect?

@gaogaotiantian
Copy link
MemberAuthor

Oh, it seems likeautomerge is no longer working -#103739

Copy link
Contributor

@hauntsaninjahauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you, this looks great!

@hauntsaninjahauntsaninja merged commit3686013 intopython:mainApr 24, 2023
@gaogaotiantiangaogaotiantian deleted the ast-sourcefile-optimization branchApril 24, 2023 05:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn left review comments

@AA-TurnerAA-TurnerAA-Turner approved these changes

@hauntsaninjahauntsaninjahauntsaninja approved these changes

@isidenticalisidenticalisidentical approved these changes

Assignees

No one assigned

Labels

performancePerformance or resource usagestdlibStandard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gaogaotiantian@isidentical@sobolevn@AA-Turner@hauntsaninja@arhadthedev@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp