Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-87092: move assembler related code from compile.c to assemble.c#103277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 10 commits intopython:mainfromiritkatriel:cfg
Apr 11, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedApr 5, 2023
edited by bedevere-bot
Loading

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems reasonable from a fairly quick scan.

There is no change in capability or optimizations, this is just a refactor. Correct?

@@ -7389,13 +6802,17 @@ add_return_at_end(struct compiler *c, int addNone)
return SUCCESS;
}

static int cfg_to_instr_sequence(cfg_builder *g, instr_sequence *seq);

static PyCodeObject *
assemble_code_unit(struct compiler_unit *u, PyObject *const_cache,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is this name still correct? Was it ever?

It seems to do optimization and assembly.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There used to be just assemble(C) which takes the compiler and and does all the optimization and assembly. I split out assemble_code_unit (which takes just the c->u and not the whole c) and does most of what used to be in assemble(). So the name was always incorrect (assemble() called the optimizer). I think the reason it was done like this is that assemble() gets called from a number of places in the compiler (lambda, class, module, etc). So it was convenient to have one function that does opt+assemble and returns a code object.

We can rename assemble() and assemble_code_unit(). Any suggestions what to call it? something like instr_sequence_to_code_object()?

@markshannonmarkshannon self-requested a reviewApril 11, 2023 10:13
@iritkatrieliritkatriel merged commit33822d0 intopython:mainApr 11, 2023
warsaw pushed a commit to warsaw/cpython that referenced this pull requestApr 11, 2023
aisk pushed a commit to aisk/cpython that referenced this pull requestApr 18, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this pull requestJun 2, 2023
iritkatriel added a commit that referenced this pull requestJun 3, 2023
@iritkatrieliritkatriel deleted the cfg branchJuly 25, 2023 18:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@markshannonmarkshannonmarkshannon approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@iritkatriel@markshannon@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp