Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-103092: Isolate winreg#103250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 34 commits intopython:mainfromaisk:isolate-winreg
Apr 17, 2023
Merged

Conversation

aisk
Copy link
Member

@aiskaisk commentedApr 4, 2023•
edited by bedevere-bot
Loading

@aiskaisk requested a review froma team as acode ownerApril 4, 2023 16:08
@aiskaisk marked this pull request as draftApril 4, 2023 16:09
aiskand others added4 commitsApril 6, 2023 15:25
@aiskaisk marked this pull request as ready for reviewApril 7, 2023 16:50
@Eclips4
Copy link
Member

Eclips4 commentedApr 8, 2023•
edited
Loading

Hm.. CI/CD says there is a certain amount of refleaks

@aisk
Copy link
MemberAuthor

aisk commentedApr 8, 2023

Yes, working on it

Eclips4 reacted with thumbs up emoji

@erlend-aaslanderlend-aasland self-requested a reviewApril 8, 2023 19:48
@erlend-aaslanderlend-aasland changed the titlegh-103092: isolate winreggh-103092: Isolate winregApr 8, 2023
aiskand others added10 commitsApril 9, 2023 13:59
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
…EFts0.rstCo-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
using PyModule_GetState instead of _PyModule_GetState
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, I think we're soon ready for landing (and of course a thumbs up from Steve or someone else from the Windows team).

I left some more nit picks :)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
aiskand others added6 commitsApril 10, 2023 17:37
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Kirill <80244920+Eclips4@users.noreply.github.com>
aiskand others added2 commitsApril 11, 2023 23:14
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@aiskaisk mentioned this pull requestApr 11, 2023
aiskand others added2 commitsApril 12, 2023 20:35
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@erlend-aasland
Copy link
Contributor

Thanks,@aisk!

Let's wait for Steve's thumbs up before we land this.

@aisk
Copy link
MemberAuthor

Great thanks for helping and review this!@erlend-aasland

erlend-aasland reacted with heart emoji

@zooba
Copy link
Member

Seems okay to me, though I'm not really up on these conversions. If all the tests (esp. refleak tests) are still passing, it's presumably fine.

erlend-aasland and aisk reacted with heart emoji

@erlend-aaslanderlend-aasland merged commitd83faf7 intopython:mainApr 17, 2023
@aiskaisk deleted the isolate-winreg branchApril 18, 2023 04:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@arhadthedevarhadthedevarhadthedev left review comments

@Eclips4Eclips4Eclips4 left review comments

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@zoobazoobaAwaiting requested review from zooba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@aisk@Eclips4@erlend-aasland@zooba@arhadthedev@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp