Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
Fix a compiler warning in _xxsubinterpretermodule.c#103245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
_xxsubinterpreter. Unlike newly allocated PyObject structs or globalstructs, stack-allocated structs are not initialised, and a few places inthe code expect the _sharedexception struct data to be either NULL orinitialised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
In my opinion, the fix in#103048 is slightly better. Function wise they are equivalent as of now, but |
Fix a (correct) warning about potential uses of uninitialized memory in_xxsubinterpreter. Unlike newly allocated PyObject structs or globalstructs, stack-allocated structs are not initialised, and a few places inthe code expect the _sharedexception struct data to be either NULL orinitialised.
Fix a (correct) warning about potential uses of uninitialized memory in_xxsubinterpreter. Unlike newly allocated PyObject structs or globalstructs, stack-allocated structs are not initialised, and a few places inthe code expect the _sharedexception struct data to be either NULL orinitialised.
Fix a (correct) warning about potential uses of uninitialized memory in _xxsubinterpreter. Unlike newly allocated PyObject structs or global structs, stack-allocated structs are not initialised, and a few places in the code expect the _sharedexception struct data to be NULL when not set.