Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-101100: Use list of 'dirty' docs, with warnings, instead of a clean list#103191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good overall, thanks, just a couple comments.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks!
…a clean list (python#103191)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
…a clean list (python#103191)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
As suggested in#103116 (comment), keep a "dirty" list of docs with warnings, instead of a "clean" list of docs with warnings.
This means we have a checklist of files to work on to clean, and any new files added to the
Doc/
directory would by default be tested with nitpicks enabled.The functionality is essentially the same, the clean docs are
touch
ed and rebuilt.In calculating the clean files:
*.rst
files fromDoc/
Doc/venv/
Doc/tools/dirty-files.txt
Doc/includes/wasm-notavail.rst
andDoc/whatsnew/changelog.rst
, which would trigger dirty files to be rebuilt