Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-101100: Use list of 'dirty' docs, with warnings, instead of a clean list#103191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 4 commits intopython:mainfromhugovk:docs-dirty-list
Apr 3, 2023

Conversation

hugovk
Copy link
Member

@hugovkhugovk commentedApr 2, 2023
edited by bedevere-bot
Loading

As suggested in#103116 (comment), keep a "dirty" list of docs with warnings, instead of a "clean" list of docs with warnings.

This means we have a checklist of files to work on to clean, and any new files added to theDoc/ directory would by default be tested with nitpicks enabled.

The functionality is essentially the same, the clean docs aretouched and rebuilt.

In calculating the clean files:

  1. start with all*.rst files fromDoc/
  2. remove any fromDoc/venv/
  3. remove files listed inDoc/tools/dirty-files.txt
  4. removeDoc/includes/wasm-notavail.rst andDoc/whatsnew/changelog.rst, which would trigger dirty files to be rebuilt

Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good overall, thanks, just a couple comments.

hugovkand others added2 commitsApril 3, 2023 18:05
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

@hugovkhugovk merged commit24facd6 intopython:mainApr 3, 2023
@hugovkhugovk deleted the docs-dirty-list branchApril 3, 2023 18:59
gaogaotiantian pushed a commit to gaogaotiantian/cpython that referenced this pull requestApr 8, 2023
…a clean list (python#103191)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
warsaw pushed a commit to warsaw/cpython that referenced this pull requestApr 11, 2023
…a clean list (python#103191)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@arhadthedevarhadthedevarhadthedev left review comments

@CAM-GerlachCAM-GerlachCAM-Gerlach left review comments

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@hugovk@arhadthedev@CAM-Gerlach@AlexWaygood@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp